GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-90868: Add _PyStaticObject_CheckRefcnt() function by vstinner · Pull Request #99261 · python/cpython

Conversation

vstinner commented Nov 8, 2022 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

Add _PyStaticObject_CheckRefcnt() function to make _PyStaticObjects_CheckRefcnt() shorter. Use
_PyObject_ASSERT_FAILED_MSG() to log the object causing the fatal error.

Issue: Share global string identifiers in deepfreeze #90868

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

vstinner added the skip news label

Nov 8, 2022

bedevere-bot mentioned this pull request

Nov 8, 2022

Share global string identifiers in deepfreeze #90868

Closed

bedevere-bot added the awaiting core review label

Nov 8, 2022

vstinner commented Nov 8, 2022

Copy link

Copy Markdown

Member Author

@ericsnowcurrently @kumaraditya303: This PR makes _PyStaticObjects_CheckRefcnt() more readable and shorter, what do you think?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ericsnowcurrently requested changes

Nov 8, 2022

View reviewed changes

ericsnowcurrently left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one suggestion. Otherwise this looks good.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Tools/build/generate_global_objects.py Outdated

Comment on lines +390 to +397

		static inline void
		_PyStaticObject_CheckRefcnt(PyObject *obj) {
		if (Py_REFCNT(obj) < _PyObject_IMMORTAL_REFCNT) {
		_PyObject_ASSERT_FAILED_MSG(obj,
		"immortal object has less refcnt than expected "
		"_PyObject_IMMORTAL_REFCNT");
		}
		}

ericsnowcurrently Nov 8, 2022

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather that being part of the generated code, you could put this directly in pycore_global_objects_fini_generated.h, before the /* The following is auto-generated by Tools/build/generate_global_objects.py. */ marker line.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

vstinner Nov 8, 2022

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha, I didn't notice that only some parts of this file are generated. Ok, I added my new function at the top.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bedevere-bot added awaiting changes and removed awaiting core review labels

Nov 8, 2022

bedevere-bot commented Nov 8, 2022

Copy link

Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          gh-90868: Add _PyStaticObject_CheckRefcnt() function

2987e19

Add _PyStaticObject_CheckRefcnt() function to make
_PyStaticObjects_CheckRefcnt() shorter. Use
_PyObject_ASSERT_FAILED_MSG() to log the object causing the fatal
error.

vstinner commented Nov 8, 2022

Copy link

Copy Markdown

Member Author

I have made the requested changes; please review again.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot added awaiting change review and removed awaiting changes labels

Nov 8, 2022

bedevere-bot commented Nov 8, 2022

Copy link

Copy Markdown

Thanks for making the requested changes!

@ericsnowcurrently: please review the changes made to this pull request.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot requested a review from ericsnowcurrently

November 8, 2022 21:46

ericsnowcurrently approved these changes

Nov 9, 2022

View reviewed changes

ericsnowcurrently left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bedevere-bot added awaiting merge and removed awaiting change review labels

Nov 9, 2022

vstinner merged commit 0124b5d into python:main

Nov 9, 2022

bedevere-bot removed the awaiting merge label

Nov 9, 2022

vstinner deleted the staticobj_check_refcnt branch

November 9, 2022 07:40

vstinner commented Nov 9, 2022

Copy link

Copy Markdown

Member Author

Merged, thanks for the review.

ericsnowcurrently reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Reviewers

ericsnowcurrently

ericsnowcurrently approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

vstinner commented Nov 8, 2022 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vstinner commented Nov 8, 2022

Uh oh!

ericsnowcurrently left a comment

Choose a reason for hiding this comment

Uh oh!

ericsnowcurrently Nov 8, 2022

Choose a reason for hiding this comment

Uh oh!

vstinner Nov 8, 2022

Choose a reason for hiding this comment

Uh oh!

bedevere-bot commented Nov 8, 2022

Uh oh!

vstinner commented Nov 8, 2022

Uh oh!

bedevere-bot commented Nov 8, 2022

Uh oh!

ericsnowcurrently left a comment

Choose a reason for hiding this comment

Uh oh!

vstinner commented Nov 9, 2022

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

vstinner commented Nov 8, 2022 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.