GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-94597: add deprecation warnings for subclassing `AbstractChildWatcher` by kumaraditya303 · Pull Request #99386 · python/cpython

Conversation

@kumaraditya303

@kumaraditya303 kumaraditya303 commented Nov 11, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: deprecate the asyncio child watchers system #94597

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@kumaraditya303
add deprecation
4fde424
@kumaraditya303
kumaraditya303 requested review from 1st1, asvetlov and gvanrossum as code owners November 11, 2022 17:48
@bedevere-bot bedevere-bot mentioned this pull request Nov 11, 2022
deprecate the asyncio child watchers system #94597
Closed
@bedevere-bot bedevere-bot added the awaiting review label Nov 11, 2022
@kumaraditya303
add whatsnew
d860adb
@kumaraditya303 kumaraditya303 added topic-asyncio skip news labels Nov 11, 2022
@kumaraditya303

kumaraditya303 commented Nov 11, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

This isn't really needed as deprecation warning will be emitted anyway when configuring the child watcher via set_child_watcher but still adding for anyone who is subclassing this but not configuring the child watcher for whatever reason.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kumaraditya303 kumaraditya303 mentioned this pull request Nov 11, 2022
Test test_asyncio prints quite a few ResourceWarnings for "unclosed event loop" #99357
Closed
@blurb-it
📜🤖 Added by blurb_it.
26f02e2
@kumaraditya303 kumaraditya303 removed the skip news label Nov 11, 2022
gvanrossum
gvanrossum approved these changes Nov 11, 2022
View reviewed changes

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Do double check the appearance of the deprecation note.)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Doc/library/asyncio-policy.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Nov 11, 2022
@gvanrossum
gvanrossum merged commit aa87432 into python:main Nov 12, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Nov 12, 2022
@kumaraditya303
kumaraditya303 deleted the async-deprecate branch November 12, 2022 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes
@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

topic-asyncio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@kumaraditya303 @gvanrossum @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.