GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-81057: Move contextvars-related Globals to _PyRuntimeState by ericsnowcurrently · Pull Request #99400 · python/cpython

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented Nov 11, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This is part of the effort to consolidate global variables, to make them easier to manage and make it easier to later move some of them to PyInterpreterState.

  • Issue: [subinterpreters] Global C variables are a problem #81057

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
ericsnowcurrently added 3 commits November 11, 2022 14:25
@ericsnowcurrently
Move _empty_bitmap_node to the global objects.
f9cdf85
@ericsnowcurrently
Move _empty_hamt to PyInterpreterState.
8753d94
@ericsnowcurrently
Move _token_missing to _PyRuntimeState.
9026153
@ericsnowcurrently ericsnowcurrently added the skip news label Nov 11, 2022
@ericsnowcurrently
ericsnowcurrently requested a review from 1st1 November 11, 2022 21:30
@bedevere-bot bedevere-bot mentioned this pull request Nov 11, 2022
[subinterpreters] Global C variables are a problem #81057
Closed
@bedevere-bot bedevere-bot added the awaiting core review label Nov 11, 2022
@ericsnowcurrently
ericsnowcurrently marked this pull request as draft November 11, 2022 22:11
@ericsnowcurrently
Fix refcounts.
68076f5
@ericsnowcurrently
ericsnowcurrently marked this pull request as ready for review November 11, 2022 23:29
@ericsnowcurrently ericsnowcurrently mentioned this pull request Nov 14, 2022
gh-81057: Move Global Variables Holding Objects to _PyRuntimeState. #99487
Merged
@ericsnowcurrently
Merge branch 'main' into contextvars-global-objects
3bc8cdc
@ericsnowcurrently
ericsnowcurrently merged commit 01fa907 into python:main Nov 16, 2022
@bedevere-bot bedevere-bot removed the awaiting core review label Nov 16, 2022
@ericsnowcurrently
ericsnowcurrently deleted the contextvars-global-objects branch November 16, 2022 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@ericsnowcurrently @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.