GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.11] gh-99370: fix test_zippath_from_non_installed_posix (GH-99483) by miss-islington · Pull Request #99498 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Nov 15, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

When build with shared enabled, we need to set LD_LIBRARY_PATH
for the non-installed python environment in
test_zippath_from_non_installed_posix so that the python binary
and find and link the libpython.so.
(cherry picked from commit 1df0752)

Co-authored-by: Kai Zhang [email protected]

  • Issue: In python3.11 getpath.py calculates zip path with default prefix in a venv which breaks venv created fron non-installed python #99370

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@kkpattern @miss-islington
pythongh-99370: fix test_zippath_from_non_installed_posix (pythonGH-9…
ed733fa
…9483)

When build with shared enabled, we need to set `LD_LIBRARY_PATH`
for the non-installed python environment in
test_zippath_from_non_installed_posix so that the python binary
and find and link the libpython.so.
(cherry picked from commit 1df0752)

Co-authored-by: Kai Zhang <[email protected]>
@miss-islington
miss-islington requested a review from vsajip as a code owner November 15, 2022 01:01
@bedevere-bot bedevere-bot mentioned this pull request Nov 15, 2022
gh-99370: fix test_zippath_from_non_installed_posix #99483
Merged
@bedevere-bot bedevere-bot added skip news awaiting review tests Tests in the Lib/test dir labels Nov 15, 2022
@bedevere-bot bedevere-bot mentioned this pull request Nov 15, 2022
In python3.11 getpath.py calculates zip path with default prefix in a venv which breaks venv created fron non-installed python #99370
Closed
zooba
zooba approved these changes Nov 15, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Nov 15, 2022
@miss-islington
miss-islington merged commit b189f42 into python:3.11 Nov 15, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Nov 15, 2022
@miss-islington
miss-islington deleted the backport-1df0752-3.11 branch November 15, 2022 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zooba zooba zooba approved these changes
@vsajip vsajip Awaiting requested review from vsajip vsajip is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@miss-islington @zooba @bedevere-bot @kkpattern
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.