GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-99300: Replace Py_INCREF() with Py_NewRef() by vstinner · Pull Request #99513 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Nov 15, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Replace Py_INCREF() and Py_XINCREF() using a cast with Py_NewRef() and Py_XNewRef().

  • Issue: Replace Py_INCREF()/Py_XINCREF() usage with Py_NewRef()/Py_XNewRef() #99300

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
gh-99300: Replace Py_INCREF() with Py_NewRef()
7c79f00 
Replace Py_INCREF() and Py_XINCREF() using a cast with Py_NewRef()
and Py_XNewRef().
@vstinner vstinner added the skip news label Nov 15, 2022
@bedevere-bot bedevere-bot added the awaiting core review label Nov 15, 2022
@bedevere-bot bedevere-bot mentioned this pull request Nov 15, 2022
Replace Py_INCREF()/Py_XINCREF() usage with Py_NewRef()/Py_XNewRef() #99300
Closed
@vstinner
vstinner marked this pull request as ready for review November 15, 2022 17:36
@vstinner
vstinner requested review from 1st1, abalkin, asvetlov, gvanrossum, pganssle and rhettinger as code owners November 15, 2022 17:36
gvanrossum
gvanrossum reviewed Nov 15, 2022
View reviewed changes

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK for _asyncio and select. The others aren't my area of expertise.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
vstinner merged commit 3ed8803 into python:main Nov 16, 2022
@bedevere-bot bedevere-bot removed the awaiting core review label Nov 16, 2022
@vstinner
vstinner deleted the newref branch November 16, 2022 09:39
@vstinner

vstinner commented Nov 16, 2022

Copy link
Copy Markdown
Member Author

@gvanrossum: Thanks for your review.

It seems like GitHub automatically asked you to review your PR. I don't know how this work. Maybe it's based on .github/CODEOWNERS. I didn't want to spam all maintainers with my current refactoring work.
gvanrossum reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum left review comments
@pganssle pganssle Awaiting requested review from pganssle
@abalkin abalkin Awaiting requested review from abalkin
@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger is a code owner
@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@vstinner @gvanrossum @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.