GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.11] GH-99460: Emscripten trampolines on optimized METH_O and METH_NOARGS code paths (gh-99461) by hoodmane · Pull Request #99514 · python/cpython

Conversation

@hoodmane

@hoodmane hoodmane commented Nov 15, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Optimized code paths in ceval / bytecodes need call trampolines for Emscripten #99460

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hoodmane
hoodmane requested a review from markshannon as a code owner November 15, 2022 18:17
@bedevere-bot bedevere-bot added the skip news label Nov 15, 2022
@bedevere-bot bedevere-bot mentioned this pull request Nov 15, 2022
gh-99460 Emscripten trampolines on optimized METH_O and METH_NOARGS code paths #99461
Merged
@bedevere-bot bedevere-bot added the awaiting review label Nov 15, 2022
@hoodmane
[3.11] Emscripten trampolines on optimized METH_O and METH_NOARGS cod…
c95c1e8 
…e paths
@hoodmane
hoodmane force-pushed the ceval-emscripten-trampolines-3.11-backport branch from 896d39c to c95c1e8 Compare November 15, 2022 18:18
gvanrossum
gvanrossum approved these changes Nov 16, 2022
View reviewed changes
@gvanrossum gvanrossum changed the title [3.11] Emscripten trampolines on optimized METH_O and METH_NOARGS code paths (gh-99461) [3.11] GH-99460: Emscripten trampolines on optimized METH_O and METH_NOARGS code paths (gh-99461) Nov 16, 2022
@bedevere-bot bedevere-bot mentioned this pull request Nov 16, 2022
Optimized code paths in ceval / bytecodes need call trampolines for Emscripten #99460
Closed
@gvanrossum
gvanrossum merged commit a06fb51 into python:3.11 Nov 16, 2022
@bedevere-bot bedevere-bot removed the awaiting review label Nov 16, 2022
@hoodmane
hoodmane deleted the ceval-emscripten-trampolines-3.11-backport branch November 16, 2022 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@hoodmane @gvanrossum @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.