GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-81057: Move More Globals in Core Code to _PyRuntimeState by ericsnowcurrently · Pull Request #99516 · python/cpython

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented Nov 15, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

I've tried to minimize churn as much as possible.

  • Issue: [subinterpreters] Global C variables are a problem #81057

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
ericsnowcurrently added 16 commits November 15, 2022 09:46
@ericsnowcurrently
Drop outdated whitelist entries.
caec551
@ericsnowcurrently
Move make_pending_calls():busy to _PyRuntimeState.
f6b90ee
@ericsnowcurrently
Move urandom_cache to _PyRuntimeState.
a6be5a3
@ericsnowcurrently
Move float_format/double_format to _PyRuntimeState.
fb33ede
@ericsnowcurrently
Special-case the hash secret.
bd1a66d
@ericsnowcurrently
Re-organize the ingored list.
1da0a33
@ericsnowcurrently
Drop an old global from the ingored list.
03481e2
@ericsnowcurrently
Only initialize bloom_linebreak once in the process.
e50ea07
@ericsnowcurrently
Clarify an ignore list header.
a55e26a
@ericsnowcurrently
Move memo_statistics to the ignored list.
fd3ec40
@ericsnowcurrently
runtime.unicode_ids -> runtime.unicode_state.ids.
d04d9da
@ericsnowcurrently
Move force_ascii to _PyRuntimeState.
4e13ded
@ericsnowcurrently
Move _Py_PackageContext to _PyRuntimeState.
e8ad283
@ericsnowcurrently
Move _Py_FatalErrorFormat():reentrant to the ignored list.
22135f7
@ericsnowcurrently
Move PyFPE_counter to the ignored list.
426b34e
@ericsnowcurrently
Move _Py_UnhandledKeyboardInterrupt to _PyRuntimeState.
ffdd34a
@ericsnowcurrently ericsnowcurrently added the skip news label Nov 15, 2022
@ericsnowcurrently
ericsnowcurrently requested review from brettcannon, encukou, ncoghlan, tiran and warsaw as code owners November 15, 2022 22:18
@bedevere-bot bedevere-bot added the awaiting core review label Nov 15, 2022
@bedevere-bot bedevere-bot mentioned this pull request Nov 15, 2022
[subinterpreters] Global C variables are a problem #81057
Closed
@ericsnowcurrently
ericsnowcurrently removed request for brettcannon, encukou, ncoghlan, tiran and warsaw November 15, 2022 22:18
@ericsnowcurrently
Fix pyhash_runtime_state on Windows.
248a69c
@ericsnowcurrently
Fix pyhash_runtime_state on Windows.
a4a55d1
@ericsnowcurrently ericsnowcurrently added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 16, 2022
@bedevere-bot

bedevere-bot commented Nov 16, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit a4a55d1 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 16, 2022
@ericsnowcurrently
ericsnowcurrently merged commit 5f55067 into python:main Nov 16, 2022
@bedevere-bot bedevere-bot removed the awaiting core review label Nov 16, 2022
@ericsnowcurrently
ericsnowcurrently deleted the consolidate-core-globals-2 branch November 16, 2022 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@ericsnowcurrently @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.