GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-93649: Split float/long tests from _testcapimodule.c by erlend-aasland · Pull Request #99549 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Nov 16, 2022 •
edited by miss-islington
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Split up _testcapimodule.c #93649

Automerge-Triggered-By: GH:erlend-aasland

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@erlend-aasland
pythongh-93649: Split float/long tests from _testcapimodule.c
2405d5b
@erlend-aasland
erlend-aasland requested a review from a team as a code owner November 16, 2022 21:28
@erlend-aasland
erlend-aasland requested a review from vstinner November 16, 2022 21:28
@bedevere-bot bedevere-bot mentioned this pull request Nov 16, 2022
Split up _testcapimodule.c #93649
Open
@bedevere-bot bedevere-bot added the awaiting core review label Nov 16, 2022
@erlend-aasland erlend-aasland added the skip news label Nov 16, 2022
@erlend-aasland
float tests need PY_SSIZE_T_CLEAN
3292458
vstinner
vstinner approved these changes Nov 16, 2022
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland reacted with hooray emoji
All reactions
  • 🎉 1 reaction
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Nov 16, 2022
@erlend-aasland

erlend-aasland commented Nov 16, 2022

Copy link
Copy Markdown
Contributor Author

Thanks for the review!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland erlend-aasland added the 🤖 automerge label Nov 16, 2022
@miss-islington

miss-islington commented Nov 16, 2022

Copy link
Copy Markdown
Contributor

@erlend-aasland: Status check is done, and it's a failure or timed out ❌.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland
Merge branch 'main' into split-testcapi/numbers
8da185d
@miss-islington

miss-islington commented Nov 17, 2022

Copy link
Copy Markdown
Contributor

Status check is done, and it's a success ✅.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Nov 17, 2022

Copy link
Copy Markdown
Contributor

Sorry, I can't merge this PR. Reason: 5 of 7 required status checks are expected..
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Nov 17, 2022

Copy link
Copy Markdown
Contributor

Status check is done, and it's a success ✅.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington
miss-islington merged commit 12b5a3c into python:main Nov 17, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Nov 17, 2022
@erlend-aasland
erlend-aasland deleted the split-testcapi/numbers branch November 17, 2022 09:10
@encukou encukou mentioned this pull request Nov 22, 2022
Add missing step to C API tests instructions python/devguide#990
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@erlend-aasland @miss-islington @vstinner @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.