GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-77188: Fix pickle to handle name-mangled private methods correctly by furkanonder · Pull Request #99669 · python/cpython

Conversation

@furkanonder

@furkanonder furkanonder commented Nov 21, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Objects referencing private-mangled names do not roundtrip properly under pickling. #77188

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@furkanonder
fix pickle to handle name-mangled private methods correctly
4a3011e
@bedevere-bot bedevere-bot mentioned this pull request Nov 21, 2022
Objects referencing private-mangled names do not roundtrip properly under pickling. #77188
Closed
@bedevere-bot bedevere-bot added the awaiting review label Nov 21, 2022
furkanonder and others added 2 commits November 22, 2022 01:34
@furkanonder
Merge branch 'main' into issue-77188
84b51da
@blurb-it
📜🤖 Added by blurb_it.
ff76d07
@furkanonder furkanonder mentioned this pull request Nov 21, 2022
gh-77188: Add support for pickling private methods and nested classes #21480
Merged
nanjekyejoannah
nanjekyejoannah reviewed Nov 21, 2022
View reviewed changes

@nanjekyejoannah nanjekyejoannah left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Credit @ZackerySpytz as co-author please.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ZackerySpytz

ZackerySpytz commented Nov 22, 2022

Copy link
Copy Markdown
Contributor

Please close this PR. You have introduced a bug that was not present in my original patch, and the formatting in the news entry is not correct.

I will update the original PR, and I will probably add you as a co-author.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nanjekyejoannah

nanjekyejoannah commented Nov 22, 2022

Copy link
Copy Markdown
Contributor

Closing in favor of @ZackerySpytz PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nanjekyejoannah nanjekyejoannah closed this Nov 22, 2022
@furkanonder

furkanonder commented Dec 10, 2022

Copy link
Copy Markdown
Contributor Author

Please close this PR. You have introduced a bug that was not present in my original patch, and the formatting in the news entry is not correct.

Why am I generating a bug? Could you please explain?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nanjekyejoannah nanjekyejoannah nanjekyejoannah left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@furkanonder @ZackerySpytz @nanjekyejoannah @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.