GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-99706: unicodeobject: Fix padding in `PyASCIIObject.state` by davidhewitt · Pull Request #99707 · python/cpython

Conversation

@davidhewitt

@davidhewitt davidhewitt commented Nov 22, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Increase padding by 1 bit so that total bitfield size is 32 bits, as the fact the fields currently sum to 31 looks potentially unintended to me.

  • Issue: 3.12 - PyASCIIObject state only 31 bits in size, should be 32 #99706

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@davidhewitt
unicodeobject - PyASCIIObject state to 32 bits
2d375ce
@bedevere-bot bedevere-bot mentioned this pull request Nov 22, 2022
3.12 - PyASCIIObject state only 31 bits in size, should be 32 #99706
Closed
@bedevere-bot bedevere-bot added the awaiting review label Nov 22, 2022
@kumaraditya303
kumaraditya303 requested a review from methane November 24, 2022 08:19
kumaraditya303
kumaraditya303 approved these changes Nov 24, 2022
View reviewed changes

@kumaraditya303 kumaraditya303 left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@methane methane added skip news type-bug An unexpected behavior, bug, or error labels Nov 24, 2022
@methane methane changed the title gh-99706: unicodeobject - PyASCIIObject state to 32 bits gh-99706: unicodeobject: Fix padding in PyASCIIObject.state Nov 24, 2022
@methane
methane merged commit b4d54a3 into python:main Nov 24, 2022
@bedevere-bot bedevere-bot removed the awaiting review label Nov 24, 2022
@methane

methane commented Nov 24, 2022

Copy link
Copy Markdown
Member

Thanks.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iritkatriel iritkatriel mentioned this pull request Nov 26, 2022
gh-85858: c-api: Fix padding in PyASCIIObject #96262
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes
@methane methane Awaiting requested review from methane

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@davidhewitt @methane @kumaraditya303 @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.