GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-98724: Fix warnings on Py_SETREF() usage by vstinner · Pull Request #99781 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Nov 25, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Cast argument to the expected type.

  • Issue: Macro Py_CLEAR references argument two times. #98724

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
gh-98724: Fix warnings on Py_SETREF() usage
d19383c 
Cast argument to the expected type.
@vstinner vstinner added the skip news label Nov 25, 2022
@vstinner
vstinner requested a review from markshannon as a code owner November 25, 2022 14:20
@bedevere-bot bedevere-bot mentioned this pull request Nov 25, 2022
Macro Py_CLEAR references argument two times. #98724
Closed
@bedevere-bot bedevere-bot added the awaiting core review label Nov 25, 2022
@vstinner vstinner mentioned this pull request Nov 25, 2022
New compile warnings in Py_SETREF #99780
Closed
@vstinner

vstinner commented Nov 25, 2022

Copy link
Copy Markdown
Member Author

See #99780
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
sobolevn
sobolevn approved these changes Nov 25, 2022
View reviewed changes

@sobolevn sobolevn left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
vstinner merged commit 5556d3e into python:main Nov 25, 2022
@bedevere-bot bedevere-bot removed the awaiting core review label Nov 25, 2022
@vstinner
vstinner deleted the setref_fix_warn branch November 25, 2022 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sobolevn sobolevn sobolevn approved these changes
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@vstinner @sobolevn @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.