GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-99845: Change _PyDict_KeysSize() return type to size_t by vstinner · Pull Request #99848 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Nov 28, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Change _PyDict_KeysSize() and shared_keys_usable_size() return type from signed (Py_ssize_t) to unsigned (size_t) type.
  • new_values() argument type is now unsigned (size_t).
  • init_inline_values() now uses size_t rather than int for the 'i' iterator variable.
  • type.sizeof() implementation now uses unsigned (size_t) type.
  • Issue: PEP 670: Convert _PyObject_SIZE() and _PyObject_VAR_SIZE() macros to functions #99845

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner vstinner added the skip news label Nov 28, 2022
@vstinner
vstinner requested review from markshannon and methane as code owners November 28, 2022 17:25
@bedevere-bot bedevere-bot mentioned this pull request Nov 28, 2022
PEP 670: Convert _PyObject_SIZE() and _PyObject_VAR_SIZE() macros to functions #99845
Closed
@bedevere-bot bedevere-bot added the awaiting core review label Nov 28, 2022
@vstinner
gh-99845: Change _PyDict_KeysSize() return type to size_t
b8953e1 
* Change _PyDict_KeysSize() and shared_keys_usable_size() return type
  from signed (Py_ssize_t) to unsigned (size_t) type.
* new_values() argument type is now unsigned (size_t).
* init_inline_values() now uses size_t rather than int for the 'i'
  iterator variable.
* type.__sizeof__() implementation now uses unsigned (size_t) type.
@vstinner

vstinner commented Nov 28, 2022

Copy link
Copy Markdown
Member Author

cc @methane
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Nov 28, 2022

Copy link
Copy Markdown
Member Author

I would prefer to change _PyDict_SizeOf() return type to size_t, but it's not required to fix issue #99845, and it can impact the 3rd party frozendict project which uses it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Nov 28, 2022

Copy link
Copy Markdown
Member Author

I would prefer to change _PyDict_SizeOf() return type to size_t, but it's not required to fix issue #99845, and it can impact the 3rd party frozendict project which uses it.

Another more radical change is to move the private function to internal C API, and frozendict should call dict.__sizeof__() method instead.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
methane
methane approved these changes Nov 29, 2022
View reviewed changes

@methane methane left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The patch looks good to me.

Is Py_ssize_t recommended for container size and size_t recommended for memory size for now?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Nov 29, 2022
@vstinner
Restore new_values() assertion
3d1621a
@vstinner
vstinner merged commit 4246fe9 into python:main Nov 29, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Nov 29, 2022
@vstinner
vstinner deleted the dict_sizeof branch November 29, 2022 11:12
@vstinner

vstinner commented Nov 29, 2022

Copy link
Copy Markdown
Member Author

I was confused by assert(size > 0); is new_values(). I read it as assert(size >= 0);, to reject negative values. So I replaced it with: assert(size >= 1); which is less confusing for me :-)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@methane methane methane approved these changes
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@vstinner @methane @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.