GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||
GeezerVison is showing github.com — gh-88267: Avoid exporting functions when a static build is used by lakor64 · Pull Request #99888 · python/cpython Conversation
|
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
The change is fine, I think it does deserve a NEWS entry (under Build) though. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
✅ Deploy Preview for python-cpython-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Thank you for letting me know this (as it's my first time contributing in cpython I had no idea if this change required an entry) I've added an entry now via blurb. If I have to rebase the changes to master / modify the NEWS let me know. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Approved. I won't be around to merge today, but someone else can.
If there's a desire to backport, this should be safe enough. But it might make pre-3.12 builds a bit less predictable compared to knowing that you need to patch yourself.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
Generation of an executable's library file when python is built is static
There was an error while loading. Please reload this page.