GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-99845: _PySys_GetSizeOf() uses size_t by vstinner · Pull Request #99903 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Nov 30, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

The _PySys_GetSizeOf() function now uses an unsigned type (size_t) to compute the size, rather than a signed type (Py_ssize_t).

  • _PySys_GetSizeOf() now checks for integer overflow when adding the header size.
  • Reformat also _PySys_GetSizeOf().
  • Issue: PEP 670: Convert _PyObject_SIZE() and _PyObject_VAR_SIZE() macros to functions #99845

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
gh-99845: _PySys_GetSizeOf() uses size_t
42c0291 
The _PySys_GetSizeOf() function now uses an unsigned type (size_t) to
compute the size, rather than a signed type (Py_ssize_t).

* _PySys_GetSizeOf() now checks for integer overflow when adding the
  header size.
* Reformat also _PySys_GetSizeOf().
@vstinner vstinner added the skip news label Nov 30, 2022
@bedevere-bot bedevere-bot mentioned this pull request Nov 30, 2022
PEP 670: Convert _PyObject_SIZE() and _PyObject_VAR_SIZE() macros to functions #99845
Closed
@bedevere-bot bedevere-bot added the awaiting core review label Nov 30, 2022
@vstinner
Enhance tests
01c6f49
@vstinner vstinner closed this Dec 13, 2022
@vstinner
vstinner deleted the sys_getsizeof branch December 13, 2022 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@vstinner @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.