GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-99957: Add `frozen_default` parameter on `dataclass_transform` by debonte · Pull Request #99958 · python/cpython

Conversation

@debonte

@debonte debonte commented Dec 3, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Fix #99957

Add new frozen_default parameter on dataclass_transform in typing.py.
Update docs and tests.

@JelleZijlstra, @NeilGirdhar, @erictraut, @hauntsaninja, @pradeep90

  • Issue: Add frozen_default parameter on dataclass_transform #99957

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
NeilGirdhar and CodeByAidan reacted with heart emoji
All reactions
  • ❤️ 2 reactions
@debonte
Update docs, typing.py, tests
ab0ee4d
@debonte
debonte requested review from AlexWaygood, Fidget-Spinner, JelleZijlstra and gvanrossum as code owners December 3, 2022 00:37
@bedevere-bot bedevere-bot mentioned this pull request Dec 3, 2022
Add frozen_default parameter on dataclass_transform #99957
Closed
@bedevere-bot bedevere-bot added the awaiting review label Dec 3, 2022
hauntsaninja
hauntsaninja reviewed Dec 3, 2022
View reviewed changes

@hauntsaninja hauntsaninja left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me, though you'll need the news entry (might even be worth a What's New bullet point as well).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
JelleZijlstra reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
JelleZijlstra
JelleZijlstra reviewed Dec 3, 2022
View reviewed changes
Comment thread Lib/typing.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@debonte @JelleZijlstra
Jelle's suggestion
44e38d9 
Co-authored-by: Jelle Zijlstra <[email protected]>
@debonte debonte mentioned this pull request Dec 3, 2022
Add frozen_default parameter on dataclass_transform python/typing_extensions#101
Merged
blurb-it Bot and others added 3 commits December 3, 2022 05:58
@blurb-it
📜🤖 Added by blurb_it.
85ea950
@debonte
Merge branch 'main' into issue99957
6be4072
@debonte
Double quotes around frozen_default in news
c6158c1
sobolevn
sobolevn reviewed Dec 4, 2022
View reviewed changes
Comment thread Lib/test/test_typing.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
debonte added 2 commits December 5, 2022 13:09
@debonte
Modify tests to validate that __dataclass_transform__ actually reflec…
c949233 
…ts frozen_default value
@debonte
Merge branch 'main' into issue99957
05a6414
@debonte

debonte commented Dec 6, 2022

Copy link
Copy Markdown
Contributor Author

@JelleZijlstra, is this good to merge now?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
JelleZijlstra
JelleZijlstra approved these changes Dec 6, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Dec 6, 2022
@JelleZijlstra
JelleZijlstra merged commit 5c19050 into python:main Dec 6, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Dec 6, 2022
@debonte
debonte deleted the issue99957 branch December 6, 2022 18:12
@NeilGirdhar NeilGirdhar mentioned this pull request Feb 6, 2023
[dataclass_transform] support default parameters python/mypy#14580
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sobolevn sobolevn sobolevn left review comments
@hauntsaninja hauntsaninja hauntsaninja left review comments
@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes
@gvanrossum gvanrossum Awaiting requested review from gvanrossum
@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner
@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood AlexWaygood is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add frozen_default parameter on dataclass_transform

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@debonte @JelleZijlstra @sobolevn @hauntsaninja @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.