GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-91054: Reset static events counts in code watchers tests by itamaro · Pull Request #99978 · python/cpython

Conversation

@itamaro

@itamaro itamaro commented Dec 3, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

GH-99859 introduced new buildbot failures, as reported here.

I was able to reproduce the failures with:

./python.exe -m test -v test_capi.test_watchers -m "*TestCodeObjectWatchers*" -R 3:3

The root cause appears to be the static events counters used in the tests, when running the tests with repetitions (using the same interpreter state), the counts from the first test run affected the next runs.

This fixes it by resetting the counts when adding and clearing test watchers.

  • Issue: Add API to allow extensions to set callback function on creation and destruction of PyCodeObject #91054

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@itamaro
pythonGH-91054: Reset static events counts in code watchers tests
5a53c06
pythonGH-99859 introduced new buildbot failures, as reported [here](python#91054 (comment)).

I was able to reproduce the failures with:

```
./python.exe -m test -v test_capi.test_watchers -m "*TestCodeObjectWatchers*" -R 3:3
```

The root cause appears to be to static events counters used in the tests,
when running the tests with repetitions (using the same interpreter state),
the counts from the first test run affected the next runs.

This fixes it by resetting the counts when adding and clearing test watchers.
@bedevere-bot bedevere-bot mentioned this pull request Dec 3, 2022
Add API to allow extensions to set callback function on creation and destruction of PyCodeObject #91054
Closed
@bedevere-bot bedevere-bot added the awaiting review label Dec 3, 2022
@itamaro itamaro mentioned this pull request Dec 3, 2022
gh-91054: Add code object watchers API #99859
Merged
@AlexWaygood AlexWaygood added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Dec 3, 2022
@bedevere-bot

bedevere-bot commented Dec 3, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @AlexWaygood for commit 5a53c06 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Dec 3, 2022
@pablogsal pablogsal added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Dec 3, 2022
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Dec 3, 2022
@python python deleted a comment from bedevere-bot Dec 3, 2022
@pablogsal pablogsal added the skip news label Dec 3, 2022
@pablogsal

pablogsal commented Dec 3, 2022

Copy link
Copy Markdown
Member

Thanks a lot for the quick fix @itamaro! I will merge this if confirmed that this fixes the buildbots

itamaro reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@pablogsal pablogsal mentioned this pull request Dec 3, 2022
gh-91054: Revert "gh-91054: Add code object watchers API" #99976
Closed
@AlexWaygood

AlexWaygood commented Dec 4, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

The two buildbot failures are unrelated and already exist on main:

  • test_capi fails with "Maximum call stack size exceeded" on "wasm32-emscripten node (pthreads) 3.x" buildbot #99985
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@pablogsal
pablogsal merged commit 1012dc1 into python:main Dec 4, 2022
@bedevere-bot bedevere-bot removed the awaiting review label Dec 4, 2022
@pablogsal

pablogsal commented Dec 4, 2022

Copy link
Copy Markdown
Member

Merging this as this fixes most of the problems. Thanks a lot again @itamaro

itamaro reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@itamaro @bedevere-bot @pablogsal @AlexWaygood
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.