GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — .github: Set dynamic run-name to distinguish package name by corona10 · Pull Request #16 · python/cpython-devcontainers

Conversation

@corona10

@corona10 corona10 commented Oct 8, 2024

Copy link
Copy Markdown
Member

Screenshot from 2024-10-08 09-18-23

Currently, no way to distinguish which packages were released. It will help to distinguish job lists.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@corona10
.github: Set dynamc run-name to distinguish package name
da17987
@corona10
corona10 requested a review from brettcannon October 8, 2024 00:19
@corona10 corona10 mentioned this pull request Oct 8, 2024
Improve devcontainer build speed #8
Closed
@corona10

corona10 commented Oct 8, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

cc @trallard
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@corona10 corona10 changed the title .github: Set dynamc run-name to distinguish package name .github: Set dynamic run-name to distinguish package name Oct 8, 2024
@corona10

corona10 commented Oct 8, 2024

Copy link
Copy Markdown
Member Author

@brettcannon I would like to recommend releasing new devcontainer image after this PR is merged :)
brettcannon reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
brettcannon
brettcannon approved these changes Oct 8, 2024
View reviewed changes
@brettcannon

brettcannon commented Oct 8, 2024

Copy link
Copy Markdown
Member

@brettcannon I would like to recommend releasing new devcontainer image after this PR is merged :)

Did you want me to do it or did you want to go ahead and trigger (I honestly forgot it was a manual trigger 😅).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@corona10
corona10 merged commit 5c70ea8 into python:main Oct 9, 2024
@corona10

corona10 commented Oct 9, 2024

Copy link
Copy Markdown
Member Author

Did you want me to do it or did you want to go ahead and trigger (I honestly forgot it was a manual trigger 😅).

Well, I am not an expert on devcontainer, so I think that you should trigger from now on, including replacing the image at CPython repo :)
https://github.com/python/cpython/blob/14b44c58e195c4cdee6594a4aacf8bf95b19fcd7/.devcontainer/devcontainer.json#L2
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@brettcannon

brettcannon commented Oct 9, 2024

Copy link
Copy Markdown
Member

I think that you should trigger from now on, including replacing the image at CPython repo :)

I had thought you had set it to the latest label so it wouldn't need updating, so I guess I have something to update regardless. 😁
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@corona10

corona10 commented Oct 9, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

I had thought you had set it to the latest label so it wouldn't need updating, so I guess I have something to update regardless. 😁

I was not sure about this :) If you think that it will be safe please go ahead!
brettcannon reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannon brettcannon brettcannon approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@corona10 @brettcannon
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.