GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Broken link "Copyright" at the footer of the devguide. · Issue #653 · python/devguide

Broken link "Copyright" at the footer of the devguide. #653

New issue
Copy link
New issue
Copy link
Closed
Closed
Broken link "Copyright" at the footer of the devguide.#653
Copy link

Description

@Mariatta
Mariatta
opened on Jan 14, 2021
Issue body actions

At the bottom of the Devguide, there is a link to Copyright that points to https://devguide.python.org/copyright/ which doesn't exist.

It would be great to fix that. Not even sure where it should go. Should it just point to the license? https://github.com/python/devguide/blob/master/LICENSE
Screen Shot 2021-01-14 at 8 39 28 AM

Activity

  1. Mariatta
    added
    bug
    on Jan 14, 2021
  2. Mariatta commented on Jan 14, 2021

    @Mariatta
    Mariatta
    on Jan 14, 2021
    MemberAuthor
    More actions

    This is implemented in python-docs-theme.
    https://github.com/python/python-docs-theme/blob/c7c7b4014d620b4d6ad69d12f41bf2bbca454b08/python_docs_theme/layout.html#L48

  3. marvlyngkhoi commented on Mar 4, 2021

    @marvlyngkhoi
    marvlyngkhoi
    on Mar 4, 2021
    More actions

    Hey can I take this? If it's still open

  4. Mariatta commented on Mar 4, 2021

    @Mariatta
    Mariatta
    on Mar 4, 2021
    MemberAuthor
    More actions

    If you can fix it, then you can work on it.

  5. jablonskidev
    added a commit that references this issue on Mar 20, 2021

    Added copyright link for the devguide

    ce0e204
  6. Ahmedk-n commented on Aug 19, 2021

    @Ahmedk-n
    Ahmedk-n
    on Aug 19, 2021
    More actions

    Hey can I work on that?

  7. hugovk commented on Jan 27, 2022

    @hugovk
    hugovk
    on Jan 27, 2022
    Member
    More actions

    This is now fixed:

    • https://github.com/python/python-docs-theme/blob/1201e82bc2f5e28d365428ad73fde4700b1f52f6/python_docs_theme/layout.html#L125 now has a conditional around the copyright link
    • And anyway the devguide is now using the Furo theme instead of python_docs_theme (Switch the theme to 'furo' #679), with no broken link:

    image

  8. hugovk
    closed this as completedon Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      You are visitor 01402503 — GeezerVison does not store the pages you look up.
      Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.