Description

ezio-melotti

opened on Oct 7, 2022

Issue body actions

In python/cpython#93823 (comment) @erlend-aasland wrote a checklist about reviewing PRs.

In #914 (comment), I suggested:

SGTM -- that's a nice list. I think it would be easier to add it in a separate PR though.
Reviewing PRs is currently documented in two places:

• https://devguide.python.org/getting-started/pull-request-lifecycle/#reviewing
• https://devguide.python.org/triage/triaging/#reviewing-patches

The former has been likely written from scratch after the HG->Git migration, whereas the latter formerly documented how to review patches attached to a bpo issue and then it has been adapted to GitHub. I think the best approach would be to enhance the pull-request-lifecycle with your list, and remove the duplicated info in triaging.

Activity

1. ezio-melotti

   added

   type-featureAdditions; New content or section neededAdditions; New content or section needed

   on Oct 7, 2022
2. erlend-aasland commented on Oct 10, 2022

   

   erlend-aasland

   on Oct 10, 2022

   Contributor

   More actions

   Thanks for the PR! Can we close this?
3. ezio-melotti commented on Oct 12, 2022

   

   ezio-melotti

   on Oct 12, 2022

   MemberAuthor

   More actions

   #914 only included the changes that I had initially created, and I now merged it to keep things moving incrementally like Diataxis suggests.
   The checklist you suggested in the comment linked above is more comprehensive and can still be integrated in the devguide to improve the current checklist, so I opened this issue as a reminder.
4. abdnafees commented on Nov 24, 2022

   

   abdnafees

   on Nov 24, 2022

   Contributor

   More actions

   @ezio-melotti Can I please work on this issue?
5. willingc

   added

   type-bugEditing of existing content neededEditing of existing content needed

   topic-triage

   topic-pull requests

   type-featureAdditions; New content or section neededAdditions; New content or section needed

   and removed

   type-featureAdditions; New content or section neededAdditions; New content or section needed

   on Oct 11, 2023

Issue actions