GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix remaining broken links. by ezio-melotti · Pull Request #1013 · python/devguide

Conversation

@ezio-melotti

@ezio-melotti ezio-melotti commented Dec 25, 2022

Copy link
Copy Markdown
Member

This PR fixes the remaining broken links and closes #681.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ezio-melotti
Fix remaining broken links.
b2cc97b
@ezio-melotti ezio-melotti added the bug label Dec 25, 2022
@ezio-melotti
ezio-melotti requested a review from hugovk December 25, 2022 05:54
@ezio-melotti ezio-melotti self-assigned this Dec 25, 2022
ezio-melotti
ezio-melotti commented Dec 25, 2022
View reviewed changes
Comment thread developer-workflow/grammar.rst
:cpy-file:`Doc/library/token-list.inc`. If you change both ``python.gram``
and ``Tokens``, run ``make regen-token`` before ``make regen-pegen``.
changing it, run ``make regen-token`` to regenerate
:cpy-file:`Include/internal/pycore_token.h`, :cpy-file:`Parser/token.c`,

@ezio-melotti ezio-melotti Dec 25, 2022

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Include/token.h was renamed to Include/internal/pycore_token.h (the rest is paragraph reflow).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
CAM-Gerlach reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
Comment thread developer-workflow/grammar.rst
Then run ``make regen-ast`` to regenerate :cpy-file:`Include/Python-ast.h`
and :cpy-file:`Python/Python-ast.c`.
Then run ``make regen-ast`` to regenerate
:cpy-file:`Include/internal/pycore_ast.h` and :cpy-file:`Python/Python-ast.c`.

@ezio-melotti ezio-melotti Dec 25, 2022

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Include/Python-ast.h was moved to Include/internal/pycore_ast.h.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
CAM-Gerlach reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
Comment thread internals/compiler.rst
statement in the ``stack_effect()`` function in :cpy-file:`Python/compile.c`.
If the new opcode has a jump target, you will need to update macros and
'switch' statements in :cpy-file:`Python/peephole.c`. If it affects a control
'switch' statements in :cpy-file:`Python/compile.c`. If it affects a control

@ezio-melotti ezio-melotti Dec 25, 2022

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The relevant code was apparently moved into Python/compile.c in python/cpython#21517.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
CAM-Gerlach reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
Comment thread internals/compiler.rst
Comment on lines -582 to -586
* :cpy-file:`Python/peephole.c`: Optimizes the bytecode.

* :cpy-file:`Python/pyarena.c`: Implementation of the arena memory manager.

* :cpy-file:`Python/wordcode_helpers.h`: Helpers for generating bytecode.

@ezio-melotti ezio-melotti Dec 25, 2022

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both got merged into Python/compile.c, which is already listed above, so I removed these.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
CAM-Gerlach reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
CAM-Gerlach
CAM-Gerlach approved these changes Dec 25, 2022
View reviewed changes

@CAM-Gerlach CAM-Gerlach left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One not-directly-related comment, but LGTM at least from a basic source diff inspection and spot-checking the rendered preview

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread developer-workflow/grammar.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@ezio-melotti @CAM-Gerlach
Add link to Tools/peg_generator.
5d24c81 
Co-authored-by: C.A.M. Gerlach <[email protected]>
hugovk
hugovk approved these changes Dec 25, 2022
View reviewed changes

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🎄

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ezio-melotti reacted with hooray emoji
All reactions
  • 🎉 1 reaction
@hugovk
hugovk merged commit c0e1638 into python:main Dec 25, 2022
@ezio-melotti
ezio-melotti deleted the fix-broken-links branch December 25, 2022 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes
@CAM-Gerlach CAM-Gerlach CAM-Gerlach approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@ezio-melotti ezio-melotti

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix broken links in the Devguide

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@ezio-melotti @hugovk @CAM-Gerlach
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.