GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Bump macOS build recommendations to OpenSSL v3.0 by erlend-aasland · Pull Request #1112 · python/devguide

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Jun 8, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Fixes #1111

📚 Documentation preview 📚: https://cpython-devguide--1112.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@erlend-aasland
pythongh-1111: Bump macOS build recommendations to OpenSSL v3.0
e6fd8be
@erlend-aasland
erlend-aasland requested a review from ned-deily June 8, 2023 22:24
@erlend-aasland erlend-aasland linked an issue Jun 8, 2023 that may be closed by this pull request
Update macOS build recommendations to use OpenSSL 3.0 #1111
Closed
@erlend-aasland erlend-aasland changed the title gh-1111: Bump macOS build recommendations to OpenSSL v3.0 Bump macOS build recommendations to OpenSSL v3.0 Jun 8, 2023
@erlend-aasland erlend-aasland mentioned this pull request Jun 8, 2023
CI: Bump macOS build to use OpenSSL v3.0 python/cpython#105538
Merged
@ned-deily
Simplify recipes by:
d7443d1 
1. removing references to 3.7 which will be end-of-life shortly
   and otherwise would require including OpenSSL 1.1.1 libs.
2. removing MacPorts recipe for 3.10 and earlier because there
   are conflicts with the use of --with-openssl and the use of
   CPPFLAGS/LDFLAGS.
ned-deily
ned-deily reviewed Jun 8, 2023
View reviewed changes

@ned-deily ned-deily left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I've pushed some changes to the PR. Rather than try to differentiate between OpenSSL 1.1.1 and 3.x, which would complicate things (like the brew installs) and since we want to get to 3.0 anyway, let's just bite the bullet here. I've also simplified the MacPorts recipes by removing the suggestion for 3.10 and earlier as that doesn't quite build correctly.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@erlend-aasland

erlend-aasland commented Jun 9, 2023

Copy link
Copy Markdown
Contributor Author

Thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland

erlend-aasland commented Jun 9, 2023

Copy link
Copy Markdown
Contributor Author

LGTM
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland
erlend-aasland merged commit 7620395 into python:main Jun 9, 2023
@erlend-aasland
erlend-aasland deleted the macos-openssl3 branch June 9, 2023 04:56
@ezio-melotti ezio-melotti mentioned this pull request Jul 13, 2024
Use latest version of OpenSSL #1349
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ned-deily ned-deily ned-deily left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

OpenSSL 3
Status: No status

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update macOS build recommendations to use OpenSSL 3.0

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@erlend-aasland @ned-deily
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.