GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add guidelines for C API return values by erlend-aasland · Pull Request #1123 · python/devguide

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Jun 23, 2023 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

📚 Documentation preview 📚: https://cpython-devguide--1123.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@erlend-aasland
Add guidelines for C API return values
91c2a05
@erlend-aasland erlend-aasland linked an issue Jun 23, 2023 that may be closed by this pull request
Document the preferred style for API functions with three, four or five-way returns #1121
Closed
@erlend-aasland erlend-aasland mentioned this pull request Jun 23, 2023
Document the preferred style for API functions with three, four or five-way returns #1121
Closed
@erlend-aasland
Be explicit about what a return value is
e4959a3
@erlend-aasland
erlend-aasland requested review from encukou, markshannon and vstinner June 23, 2023 11:50
@erlend-aasland
Wording
1baa415
markshannon
markshannon approved these changes Jun 23, 2023
View reviewed changes

@markshannon markshannon left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, as a first step.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland reacted with hooray emoji
All reactions
  • 🎉 1 reaction
@erlend-aasland erlend-aasland mentioned this pull request Jun 23, 2023
Document that infallible functions should be avoided #1122
Closed
@erlend-aasland erlend-aasland linked an issue Jun 23, 2023 that may be closed by this pull request
Document that infallible functions should be avoided #1122
Closed
vstinner
vstinner reviewed Jun 23, 2023
View reviewed changes
Comment thread developer-workflow/c-api.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
CAM-Gerlach
CAM-Gerlach reviewed Jun 23, 2023
View reviewed changes

@CAM-Gerlach CAM-Gerlach left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple small textual tweaks, otherwise LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread developer-workflow/c-api.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread developer-workflow/c-api.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland @CAM-Gerlach
Apply suggestions from CAM's review
8458b6f 
Co-authored-by: C.A.M. Gerlach <[email protected]>
CAM-Gerlach
CAM-Gerlach approved these changes Jun 23, 2023
View reviewed changes

@CAM-Gerlach CAM-Gerlach left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @erlend-aasland !

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland reacted with hooray emoji
All reactions
  • 🎉 1 reaction
This was referenced Jun 24, 2023
Inconsistency in success/failure return values capi-workgroup/problems#25
Open
Ambiguous return values capi-workgroup/problems#1
Open
@erlend-aasland

erlend-aasland commented Jun 25, 2023

Copy link
Copy Markdown
Contributor Author

Unless there are further remarks, I consider landing this early the coming week.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner
vstinner approved these changes Jun 26, 2023
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@erlend-aasland

erlend-aasland commented Jun 26, 2023

Copy link
Copy Markdown
Contributor Author

Thanks for the reviews!

FTR, I also got a thumbs up by Thomas Wouters for this PR.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland
erlend-aasland merged commit 3f08d25 into python:main Jun 26, 2023
@erlend-aasland
erlend-aasland deleted the c-api/guidelines-return-value branch June 26, 2023 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes
@markshannon markshannon markshannon approved these changes
@CAM-Gerlach CAM-Gerlach CAM-Gerlach approved these changes
@encukou encukou Awaiting requested review from encukou

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Document that infallible functions should be avoided Document the preferred style for API functions with three, four or five-way returns

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@erlend-aasland @vstinner @markshannon @CAM-Gerlach
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.