GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add "how to" for the critical_section Argument Clinic directive. by colesbury · Pull Request #1217 · python/devguide

Conversation

@colesbury

@colesbury colesbury commented Nov 10, 2023 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

See also python/cpython#111903.

📚 Documentation preview 📚: https://cpython-devguide--1217.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@colesbury
Add "how to" for the critical_section Argument Clinic directive.
088c8a1 
See also python/cpython#111903.
@colesbury
colesbury requested a review from erlend-aasland November 10, 2023 21:50
@colesbury colesbury mentioned this pull request Nov 10, 2023
gh-111903: Add @critical_section directive to Argument Clinic. python/cpython#111904
Merged
erlend-aasland
erlend-aasland approved these changes Nov 14, 2023
View reviewed changes

@erlend-aasland erlend-aasland left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread development-tools/clinic.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood @erlend-aasland
SemBr
6a80036 
Co-authored-by: Erlend E. Aasland <[email protected]>
AlexWaygood
AlexWaygood reviewed Nov 14, 2023
View reviewed changes
Comment thread development-tools/clinic.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread development-tools/clinic.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@colesbury @AlexWaygood
Apply suggestions from code review
6df4ecd 
Co-authored-by: Alex Waygood <[email protected]>
AlexWaygood
AlexWaygood approved these changes Nov 14, 2023
View reviewed changes

@AlexWaygood AlexWaygood left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
ezio-melotti
ezio-melotti approved these changes Nov 14, 2023
View reviewed changes
@AlexWaygood
AlexWaygood merged commit 679d64b into python:main Nov 14, 2023
@erlend-aasland

erlend-aasland commented Nov 14, 2023

Copy link
Copy Markdown
Contributor

Thanks, everyone!
colesbury, AlexWaygood, and ezio-melotti reacted with hooray emoji
All reactions
  • 🎉 3 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@colesbury
colesbury deleted the critical_sections branch November 14, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk left review comments
@erlend-aasland erlend-aasland erlend-aasland approved these changes
@ezio-melotti ezio-melotti ezio-melotti approved these changes
@AlexWaygood AlexWaygood AlexWaygood approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@colesbury @erlend-aasland @hugovk @ezio-melotti @AlexWaygood
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.