GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Update `translation/translators.rst` by StanFromIreland · Pull Request #1576 · python/devguide

Conversation

StanFromIreland commented Jun 16, 2025 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

~~This is a very rough draft that has been opened for the purpose of asking some questions and is subject to a lot of change, some of which I have already done locally.~~

There are some small changes to coordinating.rst in this pull request which came up as I was working on this.

cc @willingc

📚 Documentation preview 📚: https://cpython-devguide--1576.org.readthedocs.build/documentation/translations

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Initial

9ca670a

StanFromIreland commented

Jun 16, 2025

View reviewed changes

Comment thread

documentation/translations/translating.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

documentation/translations/translating.rst Outdated

Comment on lines +35 to +36

		- `AFPy/python-docs-fr <https://git.afpy.org/AFPy/python-docs-fr/>`_
		:github:`Mirror <python/python-docs-fr>`

StanFromIreland Jun 16, 2025

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @JulienPalard Is this correct, it is what I gathered from the repositories though it is in French so I may be wrong?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

rffontenelle Jun 16, 2025

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is correct. French translation happens at AFPy's Gitea and are simply mirrored to GitHub.

Instead of "GitHub" or "AFPy", there could be "repo" or "repository" text which links to the proper translation repository (for all rows in the table). Please add a comma before "Mirror"

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

StanFromIreland and m-aciek reacted with thumbs up emoji

All reactions

👍 2 reactions

Comment thread

documentation/translations/translating.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

documentation/translations/translating.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

documentation/translations/translating.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

documentation/translations/translating.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

documentation/translations/translating.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

documentation/translations/translating.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

documentation/translations/coordinating.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

documentation/translations/coordinating.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

rffontenelle suggested changes

Jun 16, 2025

View reviewed changes

Comment thread

documentation/translations/coordinating.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

documentation/translations/translating.rst Outdated

Comment on lines +35 to +36

		- `AFPy/python-docs-fr <https://git.afpy.org/AFPy/python-docs-fr/>`_
		:github:`Mirror <python/python-docs-fr>`

rffontenelle Jun 16, 2025

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is correct. French translation happens at AFPy's Gitea and are simply mirrored to GitHub.

Instead of "GitHub" or "AFPy", there could be "repo" or "repository" text which links to the proper translation repository (for all rows in the table). Please add a comma before "Mirror"

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

StanFromIreland and m-aciek reacted with thumbs up emoji

All reactions

👍 2 reactions

Comment thread

documentation/translations/translating.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

documentation/translations/translating.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

documentation/translations/translating.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

documentation/translations/translating.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

documentation/translations/translating.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.


          Rafael's feedback

m-aciek requested changes

Jun 16, 2025

View reviewed changes

Comment thread

documentation/translations/coordinating.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

nedbat reviewed

Jun 16, 2025

View reviewed changes

Comment thread

core-developers/experts.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

nedbat reviewed

Jun 16, 2025

View reviewed changes

Comment thread

documentation/translations/coordinating.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

nedbat reviewed

Jun 16, 2025

View reviewed changes

Comment thread

documentation/translations/coordinating.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

nedbat reviewed

Jun 16, 2025

View reviewed changes

Comment thread

documentation/translations/translating.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

nedbat reviewed

Jun 16, 2025

View reviewed changes

Comment thread

documentation/translations/translating.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

nedbat reviewed

Jun 16, 2025

View reviewed changes

Comment thread

documentation/translations/translating.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

willingc reviewed

Jun 17, 2025

View reviewed changes

Comment thread

documentation/translations/coordinating.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

documentation/translations/coordinating.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

willingc reviewed

Jun 17, 2025

View reviewed changes

Comment thread

documentation/translations/coordinating.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.


          Further updates and amendments

b42731a

StanFromIreland marked this pull request as ready for review

June 17, 2025 10:20

rffontenelle previously requested changes

Jun 17, 2025

View reviewed changes

Comment thread

documentation/translations/translating.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

documentation/translations/translating.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.


          Rafael's review

d4e50f7

StanFromIreland requested review from m-aciek, nedbat, rffontenelle and willingc

June 19, 2025 08:26

willingc approved these changes

Jun 19, 2025

View reviewed changes

willingc left a comment

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @StanFromIreland, I rereviewed. Thanks for putting together. I have only one small grammar nit and a question about max depth. Neither are blockers so I'm going to approve this PR. After I hear back from you or others, I am happy to merge.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

documentation/translations/coordinating.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

documentation/translations/index.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.


          Carol’s suggestion

7e0bbc7

Co-authored-by: Carol Willing <[email protected]>

m-aciek requested changes

Jun 19, 2025

View reviewed changes

Comment thread

documentation/translations/coordinating.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

documentation/translations/coordinating.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

documentation/translations/translating.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

documentation/translations/translating.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

documentation/translations/translating.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

documentation/translations/translating.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

documentation/translations/translating.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

documentation/translations/translating.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

documentation/translations/translating.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

documentation/translations/translating.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

m-aciek commented Jun 19, 2025

Copy link

Copy Markdown

Contributor

Thank you for your work on it! I've left some comments.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

m-aciek reviewed

Jun 19, 2025

View reviewed changes

Comment thread

documentation/translations/index.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

documentation/translations/translating.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

documentation/translations/translating.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

StanFromIreland requested review from JulienPalard and rffontenelle and removed request for rffontenelle

June 20, 2025 08:21


          Maciek's review

6f22c65

m-aciek requested changes

Jun 20, 2025

View reviewed changes

m-aciek left a comment •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing my comments, answering some of the replies.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

documentation/translations/translating.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

documentation/translations/translating.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

documentation/translations/translating.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

hugovk previously requested changes

Jun 20, 2025

View reviewed changes

Comment thread

documentation/translations/coordinating.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

documentation/translations/coordinating.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

documentation/translations/coordinating.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

documentation/translations/coordinating.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

documentation/translations/coordinating.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

documentation/translations/translating.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

documentation/translations/translating.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

documentation/translations/translating.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

documentation/translations/translating.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

documentation/translations/translating.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.


          Reviews

3b00bdd

StanFromIreland requested review from hugovk and m-aciek

June 20, 2025 10:35

m-aciek approved these changes

Jun 20, 2025

View reviewed changes

Comment thread

documentation/translations/translating.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

documentation/translations/translating.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.


          Maciek's review + comma

487809c

willingc reviewed

Jun 20, 2025

View reviewed changes

willingc left a comment

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest that we incorporate some of @hugovk's suggestions. Thanks @StanFromIreland.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

documentation/translations/coordinating.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

documentation/translations/coordinating.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

willingc commented Jun 20, 2025

Copy link

Copy Markdown

Collaborator

@hugovk I'm leaving this in your capable hands to merge when your suggestions are incorporated. @StanFromIreland Thanks for working together with folks on the review. I'm loving how these docs are coming together.

StanFromIreland reacted with heart emoji

All reactions

❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          Hugo’s suggestions

Co-authored-by: Hugo van Kemenade <[email protected]>

willingc mentioned this pull request

Jun 20, 2025

Move docs build scripts info from intro paragraph to the Coordinating FAQ for translations #1585

Closed

willingc approved these changes

Jun 20, 2025

View reviewed changes

willingc dismissed stale reviews from hugovk and rffontenelle

June 20, 2025 19:26

Suggestions were added and #1585 added to address the build scripts suggestion.

willingc merged commit 3a8b71e into python:main

Jun 20, 2025

willingc commented Jun 20, 2025

Copy link

Copy Markdown

Collaborator

Thanks @StanFromIreland and to everyone who reviewed this PR. Working together we now have much clearer info for coordinators and translators. 🚀 Keep up the collaboration. ☀️

StanFromIreland reacted with rocket emoji

All reactions

🚀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

StanFromIreland deleted the translating branch

June 20, 2025 19:38

StanFromIreland commented Jun 20, 2025

Copy link

Copy Markdown

Member Author

Many thanks to everyone who reviewed!

willingc reacted with heart emoji

All reactions

❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

rffontenelle commented Jun 20, 2025

Copy link

Copy Markdown

Contributor

Thanks @StanFromIreland and everyone that contributed for improving translation docs!

StanFromIreland and willingc reacted with heart emoji

All reactions

❤️ 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

hugovk commented Jun 23, 2025

Copy link

Copy Markdown

Member

@StanFromIreland Please could you check the new warnings?

contrib/doc/translating.rst:12: WARNING: undefined label: 'translating' [ref.ref]
contrib/index.rst:78: WARNING: unknown document: 'documentation/translations' [ref.doc]
index.rst:179: WARNING: undefined label: 'translating' [ref.ref]

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

StanFromIreland commented Jun 23, 2025

Copy link

Copy Markdown

Member Author

@hugovk They are addressed in #1587 I can move them to a separate pr if you want?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

hugovk commented Jun 23, 2025

Copy link

Copy Markdown

Member

It can wait, thanks!

willingc reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

StanFromIreland mentioned this pull request

Jul 10, 2025

Fix some broken links to translation pages #1603

Closed

StanFromIreland mentioned this pull request

Jul 24, 2025

docs: add label to translating so it can be referenced #1619

Merged

1 task done

Reviewers

willingc

willingc approved these changes

m-aciek

m-aciek approved these changes

nedbat

Awaiting requested review from nedbat

JulienPalard

Awaiting requested review from JulienPalard

rffontenelle

Awaiting requested review from rffontenelle

hugovk

Awaiting requested review from hugovk

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

StanFromIreland commented Jun 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

StanFromIreland Jun 16, 2025

Choose a reason for hiding this comment

Uh oh!

rffontenelle Jun 16, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rffontenelle Jun 16, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

willingc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

m-aciek commented Jun 19, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

m-aciek left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

StanFromIreland commented Jun 16, 2025 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

m-aciek left a comment •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.