GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [don't merge yet] Reference python-docs-theme when building docs without make by Mariatta · Pull Request #333 · python/devguide

Conversation

@Mariatta

@Mariatta Mariatta commented Mar 1, 2018

Copy link
Copy Markdown
Member

Only merge once python/cpython#2017 has been merged.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Mariatta
Reference python-docs-theme when building docs without make
3b4014f 
Only merge once python/cpython#2017 has been merged.
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Mar 1, 2018
@Mariatta Mariatta mentioned this pull request Mar 1, 2018
bpo-30607: Use external python-doc-theme python/cpython#2017
Merged
@ned-deily

ned-deily commented Mar 1, 2018

Copy link
Copy Markdown
Member

As I mentioned elsewhere, I really think we should remove the "Without make" section in the devguide and just refer users to the Doc README.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Mariatta

Mariatta commented Mar 1, 2018

Copy link
Copy Markdown
Member Author

Thanks @ned-deily. I've completely forgotten about that discussion. But I agree, removing the without make section makes sense. I'll close this.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Mariatta Mariatta closed this Mar 1, 2018
@Mariatta
Mariatta deleted the Mariatta-patch-1 branch March 1, 2018 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@Mariatta @ned-deily @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.