GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fixes #502: include infromation about auto-closure of bpo isssues by kumiDa · Pull Request #701 · python/devguide

Conversation

@kumiDa

@kumiDa kumiDa commented May 18, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Fixes #502

Feature that was included in PEP-595 to automatically close issue
in the bug tracker when a PR with commit message including words like-
close, closes, closed, closing, fix, fixes or fixed being used with
issue number is merged is documented in the devguide.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@kumiDa
fixes python#502: include infromation about auto-closure of bpo isssues
916d00c 
Feature that was included in PEP-595 to automatically close issue
in the bug tracker when a PR with commit message including words like-
close, closes, closed, closing, fix, fixes or fixed being used with
issue number is merged is documented in the devguide.
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label May 18, 2021
@kumiDa kumiDa mentioned this pull request May 18, 2021
Document that bpo issues can be automatically closed using commit message #502
Closed
@kumiDa

kumiDa commented May 3, 2022

Copy link
Copy Markdown
Contributor Author

@hugovk, the CLA is signed...still the CLA signing status is stated as expected.
Can you please help me with this.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood AlexWaygood closed this May 3, 2022
@AlexWaygood AlexWaygood reopened this May 3, 2022
JelleZijlstra
JelleZijlstra reviewed May 3, 2022
View reviewed changes

@JelleZijlstra JelleZijlstra left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still talks about bpo, which is no longer relevant.

Additionally, it would fit better at https://devguide.python.org/gitbootcamp/#accepting-and-merging-a-pr where we already talk about commit messages.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
kumiDa reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@ezio-melotti

ezio-melotti commented May 5, 2022

Copy link
Copy Markdown
Member

Closing since we now migrated to GitHub.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ezio-melotti ezio-melotti closed this May 5, 2022
@gvanrossum

gvanrossum commented May 5, 2022

Copy link
Copy Markdown
Member

But GitHub has a similar feature. Is that documented?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ezio-melotti

ezio-melotti commented May 6, 2022

Copy link
Copy Markdown
Member

Is that documented?

Apparently not.

Recently there was a discussion about the fact that using the auto-closing keywords is not always desirable, e.g.:

  • when the PR needs to be backported
  • when multiple PRs address the same issue

In these cases it might be better to avoid keywords and just close the issue manually once all the relevant PRs are merged. Both the keywords and recommendations on where they should be used/avoid can be documented.

I would really like to see sections with basic instructions/tips/reference for all the tools we use, but I'm still not sure what would be the best way to organize this.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ezio-melotti ezio-melotti reopened this May 6, 2022
@ezio-melotti ezio-melotti closed this May 6, 2022
@ezio-melotti ezio-melotti mentioned this pull request May 6, 2022
Document auto-closing keywords for PRs. #855
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Document that bpo issues can be automatically closed using commit message

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@kumiDa @ezio-melotti @gvanrossum @JelleZijlstra @the-knights-who-say-ni @AlexWaygood
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.