GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Add a section about how to regenerate the ABI file by pablogsal · Pull Request #903 · python/devguide

Conversation

pablogsal commented Jun 22, 2022

Copy link

Copy Markdown

Member

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Add a section about how to regenerate the ABI file

dd9e789

Signed-off-by: Pablo Galindo <[email protected]>

pablogsal force-pushed the regen branch from b21034f to dd9e789 Compare

June 22, 2022 15:30

AlexWaygood reviewed

Jun 22, 2022

View reviewed changes

AlexWaygood left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some typos :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

setup.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

setup.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

setup.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

setup.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.


          Apply suggestions from code review

d17c5f6

Co-authored-by: Alex Waygood <[email protected]>

pablogsal merged commit 3f73e7d into python:main

Jun 22, 2022

pablogsal deleted the regen branch

June 22, 2022 15:38

pablogsal commented Jun 22, 2022

Copy link

Copy Markdown

Member Author

Thanks for the review @AlexWaygood :)

AlexWaygood reacted with heart emoji

All reactions

❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

encukou reviewed

Jun 22, 2022

View reviewed changes

Comment thread

setup.rst

Comment on lines +505 to +518

		.. code-block:: bash
		# In the CPython root:
		$ docker run -v`pwd`:/src -it ubuntu:20.04 bash
		$ cd /src
		# Install dependencies to compile CPython
		$ .github/workflows/posix-deps-apt.sh
		# Install dependencies to run the ABI regeneration
		$ apt-get install -yq abigail-tools python3
		# Ensure CPython is built with all the debugging information
		$ export CFLAGS="-g3 -O0"
		# Build Python
		$ ./configure --enable-shared && make
		# Regenerate the ABI file
		$ make regen-abidump

encukou Jun 22, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a long script. Would you object to adding it to the source, and reducing the instructions to just e.g. docker run -v$(pwd):/src -w/src --rm ubuntu:20.04 bash /src/.github/workflows/regen-abidump.sh?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

pablogsal Jun 22, 2022

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I think is a good idea. Will prepare a PR

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

pablogsal Jun 22, 2022

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python/cpython#94135

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

encukou reviewed

Jun 22, 2022

View reviewed changes

Comment thread

setup.rst

		with native extensions and other tools that interact with the Python interpreter.
		See the documentation about the :ref:`release candidate <rc>` phase.

		You can regenerate the ABI file by yourself by invoking the ``regen abidump``

encukou Jun 22, 2022

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

regen-abidump, right?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

pablogsal Jun 22, 2022

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

pablogsal Jun 22, 2022

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will fix this when I update the code block after we merge python/cpython#94135

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Reviewers

encukou

encukou left review comments

AlexWaygood

AlexWaygood left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

pablogsal commented Jun 22, 2022

Uh oh!

AlexWaygood left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pablogsal commented Jun 22, 2022

Uh oh!

encukou Jun 22, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pablogsal Jun 22, 2022

Choose a reason for hiding this comment

Uh oh!

pablogsal Jun 22, 2022

Choose a reason for hiding this comment

Uh oh!

encukou Jun 22, 2022

Choose a reason for hiding this comment

Uh oh!

pablogsal Jun 22, 2022

Choose a reason for hiding this comment

Uh oh!

pablogsal Jun 22, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

encukou Jun 22, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.