GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Overhaul the labels page to reflect current GH labeling practice by ezio-melotti · Pull Request #930 · python/devguide

Conversation

@ezio-melotti

@ezio-melotti ezio-melotti commented Aug 6, 2022 •
edited by CAM-Gerlach
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This PR updates the triage/labels.rst page, that contained outdated references to removed/renamed labels and previous fields used by bpo.

The PR is still a draft. The first commit documents the existing labels. Next, most of the remaining text in the page will either be deleted or moved to other sections, since it mostly covers bpo fields. Finally, I might add more links to the relevant sections to avoid duplicating information.

This is part of CPython labels and will fix the following issues:

Fixes #296
Fixes #518
Fixes #821
Fixes #868
Fixes #929

The structure and grouping of the labels is also based on python/core-workflow#450

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

arhadthedev and FFY00 reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@ezio-melotti
Update the triage/labels.rst page.
ee69135
@ezio-melotti ezio-melotti added the type-feature Additions; New content or section needed label Aug 6, 2022
@ezio-melotti ezio-melotti self-assigned this Aug 6, 2022
@ezio-melotti
ezio-melotti marked this pull request as draft August 6, 2022 23:15
This was referenced Aug 7, 2022
Add the labels flowchart to the README. python/bedevere#500
Merged
Make it clear that the [awaiting ...] labels are for the bots only. #868
Closed
Improve state graph python/bedevere#184
Closed
Add a Sphinx role to link to GitHub labels #932
Merged
@terryjreedy

terryjreedy commented Aug 9, 2022

Copy link
Copy Markdown
Member

I don't see any mention of automerge in the patch, but see comment on #518.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ezio-melotti

ezio-melotti commented Aug 11, 2022

Copy link
Copy Markdown
Member Author

I haven't used automerge myself so, even though I'm planning to document it, I first have to figure out how it works exactly, and when it should be used.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ezio-melotti ezio-melotti mentioned this pull request Oct 7, 2022
Update the triage/triaging.rst page. #914
Merged
@ezio-melotti
Merge branch 'main' into update-labels
74f0847
ezio-melotti
ezio-melotti commented Dec 25, 2022
View reviewed changes
Comment thread core-developers/committing.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

ezio-melotti added 4 commits December 25, 2022 07:40
@ezio-melotti
Remove duplicate label.
8e3928c
@ezio-melotti
Use the :gh-label: role.
f6ac25c
@ezio-melotti
Use the :cpy-file: role.
82dae36
@ezio-melotti
(Re)move (mostly) BPO-related info.
d51c027
ezio-melotti
ezio-melotti commented Dec 25, 2022
View reviewed changes
Comment thread triage/issue-tracker.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread triage/labels.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread triage/labels.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread triage/labels.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread triage/labels.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread triage/labels.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread triage/labels.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread triage/labels.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread triage/labels.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread triage/labels.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

@ezio-melotti
ezio-melotti marked this pull request as ready for review December 25, 2022 08:03
@ezio-melotti

ezio-melotti commented Dec 25, 2022

Copy link
Copy Markdown
Member Author

I updated the PR and marked it as "ready for review". It's still not perfect, but we can start merging this and apply further improvements in separate PRs. I left some inline comments to facilitate the review.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ezio-melotti
ezio-melotti requested review from CAM-Gerlach and hugovk December 25, 2022 08:06
CAM-Gerlach
CAM-Gerlach reviewed Dec 25, 2022
View reviewed changes

@CAM-Gerlach CAM-Gerlach left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ezio-melotti , this seems like a great set of major and well-needed improvements overall. I did have a number of specific suggestions for tweaks, most minor and a few less so, as well as a handful of broader comments and questions. Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread triage/issue-tracker.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread triage/issue-tracker.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread triage/issue-tracker.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread triage/issue-tracker.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread triage/triage-team.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread triage/labels.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread triage/issue-tracker.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread triage/issue-tracker.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread triage/labels.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread triage/issue-tracker.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

@ezio-melotti @CAM-Gerlach
Apply suggestions from code review
579b6a5
Co-authored-by: C.A.M. Gerlach <[email protected]>
hugovk
hugovk reviewed Dec 26, 2022
View reviewed changes

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this!

Some suggestions mostly about preserving #anchors where appropriate.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread triage/triage-team.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread triage/triage-team.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread triage/labels.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread triage/labels.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread triage/labels.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread triage/labels.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread triage/labels.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread triage/labels.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread triage/labels.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

CAM-Gerlach
CAM-Gerlach reviewed Dec 26, 2022
View reviewed changes
Comment thread triage/labels.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

CAM-Gerlach
CAM-Gerlach reviewed Dec 26, 2022
View reviewed changes
Comment thread triage/labels.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

ezio-melotti and others added 2 commits December 27, 2022 09:50
@ezio-melotti @CAM-Gerlach @hugovk
Apply suggestions from code review
e5a4e09
Co-authored-by: C.A.M. Gerlach <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
@ezio-melotti
Fix miss-islington link markup.
9983fc2
@hugovk

hugovk commented Feb 11, 2023

Copy link
Copy Markdown
Member

This PR could also close #296.

ezio-melotti reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@CAM-Gerlach CAM-Gerlach changed the title Update the triage/labels.rst page. Overhaul the labels page to reflect current GH labeling practice Feb 14, 2023
@CAM-Gerlach

CAM-Gerlach commented Feb 14, 2023

Copy link
Copy Markdown
Member

It wouldn't let me add that one under Development for whatever reason, so I edited the OP directly (and made the others proper fix-tagged). I also fixed the title to be more useful/descriptive and less generic; refine it further as desired, of course.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ezio-melotti @CAM-Gerlach @hugovk
Add more ref targets to prevent link rotting.
a783cd3
Co-authored-by: C.A.M. Gerlach <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
ezio-melotti
ezio-melotti commented Mar 14, 2023
View reviewed changes
Comment thread triage/labels.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

ezio-melotti added 2 commits March 14, 2023 14:39
@ezio-melotti
Add other two ref targets to the "Type labels" section.
eed6680
@ezio-melotti
Address remaining review comments.
42842c4
hugovk
hugovk approved these changes Mar 14, 2023
View reviewed changes

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏷️ Thank you!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ezio-melotti reacted with eyes emoji
All reactions
  • 👀 1 reaction
@CAM-Gerlach
CAM-Gerlach self-requested a review March 15, 2023 08:01
CAM-Gerlach
CAM-Gerlach reviewed Mar 15, 2023
View reviewed changes

@CAM-Gerlach CAM-Gerlach left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a handful of final followups, ref target label tweaks and a few other fixes I spotted—all as one-click apply able suggestions—plus re-iterating one previous unresolved comment requesting reverting the "assignee" section removal that has no existing replacement, and should be iterated on in the future. Other than that, LGTM, and I resolved the other outstanding comments (aside from a couple addressed here). Thanks @ezio-melotti for all your hard work (and patience) here!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread triage/labels.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread getting-started/setup-building.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread triage/labels.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread triage/triage-team.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread triage/labels.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread triage/labels.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread triage/labels.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread triage/labels.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread triage/labels.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread triage/labels.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

ezio-melotti and others added 4 commits March 15, 2023 15:43
@ezio-melotti @CAM-Gerlach
Apply more suggestions from code review.
b3590e2
Co-authored-by: C.A.M. Gerlach <[email protected]>
@ezio-melotti
Rephrase sentence as suggested in a review comment.
7c54ccf
@ezio-melotti
Rewrap a few long lines.
89b29bb
@ezio-melotti
Restore and move the Assignees sub-section.
ee6fecd
hugovk
hugovk approved these changes Mar 15, 2023
View reviewed changes
Comment thread triage/triaging.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread triage/triaging.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

@ezio-melotti @hugovk
Fix typo.
8d8a52b
Co-authored-by: Hugo van Kemenade <[email protected]>
@CAM-Gerlach
CAM-Gerlach self-requested a review March 16, 2023 14:49
@ezio-melotti @hugovk
Fix "triager" capitalization.
52eea4d
Co-authored-by: Hugo van Kemenade <[email protected]>
CAM-Gerlach
CAM-Gerlach approved these changes Mar 16, 2023
View reviewed changes

@CAM-Gerlach CAM-Gerlach left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few final followup fixes and one minor thing I couldn't reach (that may be out of scope), otherwise LGTM, thanks! Marked everything else as resolved now.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread triage/triaging.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread triage/triaging.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread triage/triaging.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread triage/labels.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

ezio-melotti and others added 3 commits March 16, 2023 23:02
@ezio-melotti
Document the automerge label.
5f1f478
@ezio-melotti
Remove obsolete note/comment.
4db1138
@ezio-melotti @CAM-Gerlach
Minor grammar/punctuation/phrasing fixes.
ff2d0ee
Co-authored-by: C.A.M. Gerlach <[email protected]>
CAM-Gerlach
CAM-Gerlach reviewed Mar 16, 2023
View reviewed changes
Comment thread triage/labels.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

@ezio-melotti @CAM-Gerlach
Final tweaks.
9b9482f
Co-authored-by: C.A.M. Gerlach <[email protected]>
@ezio-melotti
ezio-melotti merged commit 4e6e10f into python:main Mar 16, 2023
@ezio-melotti
ezio-melotti deleted the update-labels branch March 16, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CAM-Gerlach CAM-Gerlach CAM-Gerlach approved these changes
@hugovk hugovk hugovk approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@ezio-melotti ezio-melotti

Labels

type-feature Additions; New content or section needed

Projects

CPython labels
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Document the triaged label Make it clear that the [awaiting ...] labels are for the bots only. Update label names in the triaging section Make it clearer that "automerge" exists and is preferred Add a section to explain the different GitHub PR labels

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@ezio-melotti @terryjreedy @hugovk @CAM-Gerlach
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.