GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||
GeezerVison is showing github.com — Overhaul the labels page to reflect current GH labeling practice by ezio-melotti · Pull Request #930 · python/devguide Conversation
|
|
I don't see any mention of automerge in the patch, but see comment on #518. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I haven't used |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
I updated the PR and marked it as "ready for review". It's still not perfect, but we can start merging this and apply further improvements in separate PRs. I left some inline comments to facilitate the review. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ezio-melotti , this seems like a great set of major and well-needed improvements overall. I did have a number of specific suggestions for tweaks, most minor and a few less so, as well as a handful of broader comments and questions. Thanks!
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Co-authored-by: C.A.M. Gerlach <[email protected]>
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this!
Some suggestions mostly about preserving #anchors where appropriate.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Co-authored-by: C.A.M. Gerlach <[email protected]> Co-authored-by: Hugo van Kemenade <[email protected]>
|
This PR could also close #296. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
It wouldn't let me add that one under |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Co-authored-by: C.A.M. Gerlach <[email protected]> Co-authored-by: Hugo van Kemenade <[email protected]>
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
🏷️ Thank you!
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
I had a handful of final followups, ref target label tweaks and a few other fixes I spotted—all as one-click apply able suggestions—plus re-iterating one previous unresolved comment requesting reverting the "assignee" section removal that has no existing replacement, and should be iterated on in the future. Other than that, LGTM, and I resolved the other outstanding comments (aside from a couple addressed here). Thanks @ezio-melotti for all your hard work (and patience) here!
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Co-authored-by: Hugo van Kemenade <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
A few final followup fixes and one minor thing I couldn't reach (that may be out of scope), otherwise LGTM, thanks! Marked everything else as resolved now.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Co-authored-by: C.A.M. Gerlach <[email protected]>
There was an error while loading. Please reload this page.
Co-authored-by: C.A.M. Gerlach <[email protected]>
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
Document thetriaged label
Make it clear that the [awaiting ...] labels are for the bots only.
Update label names in the triaging section
Make it clearer that "automerge" exists and is preferred
Add a section to explain the different GitHub PR labels
There was an error while loading. Please reload this page.