GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Pin sphinx-lint to fix the CI by hugovk · Pull Request #955 · python/devguide

Conversation

@hugovk

@hugovk hugovk commented Oct 6, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Between PR #954 being opened (CI passed) and merged 25 minutes later (CI failed), a new release of sphinx-lint came out with differing checks.

Let's pin it to get the CI green, and I'll open an issue to upgrade and fix the issues.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ezio-melotti reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@hugovk
Pin sphinx-lint
6d37fc9
@arhadthedev

arhadthedev commented Oct 6, 2022

Copy link
Copy Markdown
Member

new release of sphinx-lint came out with differing checks.

Or with bugs. From a code diff of python/cpython#97962:

sphinx-lint 0.6.2 yields many default role errors due to the new regular expression used for default role detection, so we don't use the version until the errors are fixed.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AA-Turner

AA-Turner commented Oct 6, 2022

Copy link
Copy Markdown
Member

Or with bugs. From a code diff of python/cpython#97962:

... the errors are fixed.

I meant the errors in CPython's reStructuredText sources in that comment, I'm assuming the changes in sphinx-lint are correct. I haven't checked either, though.

A
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra
JelleZijlstra merged commit 1e315c0 into python:main Oct 6, 2022
@JelleZijlstra

JelleZijlstra commented Oct 6, 2022

Copy link
Copy Markdown
Member

I didn't check in detail but the amount of errors in CI does suggest a bug in sphinx-lint.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hugovk
hugovk deleted the pin-sphinx-lint branch October 6, 2022 18:25
@hugovk

hugovk commented Oct 6, 2022

Copy link
Copy Markdown
Member Author

Yes, reported here: sphinx-contrib/sphinx-lint#46
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@hugovk @arhadthedev @AA-Turner @JelleZijlstra
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.