GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Move .PHONY to each section to avoid copy/paste omissions by hugovk · Pull Request #972 · python/devguide

Conversation

@hugovk

@hugovk hugovk commented Oct 21, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Similar to python/cpython#98189, the list of phony targets in the Makefile had got out of sync with the commands: clean-venv, ensure-venv and serve were missing.

I expect it will happen again because it's easy to copy and paste a target and not realise/remember to update the list of .PHONY targets at the top of the file.

Let's do as @zware suggested in python/cpython#98189 (comment) and put each one right next to its target.

We do this at Pillow and at work, it helps a lot.

(See also python/cpython#98266 to update the CPython docs Makefile and python/peps#2841 for PEPs.)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hugovk
Move .PHONY to each section to avoid copy/paste omissions
f1845b6
@hugovk hugovk mentioned this pull request Oct 21, 2022
Infra: Declare Makefile targets as phony python/peps#2841
Merged
JelleZijlstra
JelleZijlstra approved these changes Oct 21, 2022
View reviewed changes
@JelleZijlstra
JelleZijlstra merged commit 00a3bb0 into python:main Oct 21, 2022
@hugovk
hugovk deleted the fix-phony-targets branch October 21, 2022 17:53
@hugovk hugovk mentioned this pull request Nov 11, 2022
Docs: Move .PHONY to each section to avoid copy/paste omissions python/cpython#99396
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@hugovk @JelleZijlstra
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.