GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Shot in the dark fix for broken 3.10 render by hauntsaninja · Pull Request #133 · python/docsbuild-scripts

Conversation

@hauntsaninja

@hauntsaninja hauntsaninja commented Aug 6, 2022

Copy link
Copy Markdown
Contributor

CPython 3.10 docs have been repeatedly breaking, see python/cpython#91483

It seems likely to me that this is related to python/cpython#93159 (although the timeline doesn't match closely)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
m-aciek reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@hauntsaninja
Shot in the dark fix for broken 3.10 render
6ef3afb
@hauntsaninja
hauntsaninja requested a review from JulienPalard August 6, 2022 07:16
m-aciek
m-aciek approved these changes Aug 6, 2022
View reviewed changes

@m-aciek m-aciek left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To my best knowledge it should fix the issue (I left a comment with a slight improvement). Sphinx version has been bumped on 3.10 doc requirements, but the script for generating the dependecies' pins has been not updated.

Probably it would be better to try to reuse requirements.txt of a build as long as it's not broken (for EOF Python version) to have one source of truth (we maintain the requirements.txt to be correct either way).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread build_docs.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@hauntsaninja @m-aciek
Update build_docs.py
e1b2aec 
Co-authored-by: Maciej Olko <[email protected]>
@hauntsaninja hauntsaninja mentioned this pull request Aug 6, 2022
[DOC] Warnings/notes in docs including most of the page python/cpython#91483
Closed
@ned-deily

ned-deily commented Aug 6, 2022

Copy link
Copy Markdown
Member

@JulienPalard
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hauntsaninja
use strict comparison
5a80767
@JulienPalard
JulienPalard merged commit 681fd2c into python:main Aug 7, 2022
@hauntsaninja
hauntsaninja deleted the version-change branch August 7, 2022 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JulienPalard JulienPalard Awaiting requested review from JulienPalard
1 more reviewer
@m-aciek m-aciek m-aciek approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@hauntsaninja @ned-deily @m-aciek @JulienPalard
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.