GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Improve performance for ``proofread_canonicals()`` by AA-Turner · Pull Request #258 · python/docsbuild-scripts

Conversation

@AA-Turner

@AA-Turner AA-Turner commented Apr 11, 2025

Copy link
Copy Markdown
Member

Currently, proofread_canonicals() takes c. 4-5 minutes, with the vast majority of time spent reading the files from disk. This PR improves performance to c. 100-120 seconds by using multiple threads to check the files. We also switch to byte methods over re for another slight improvement, avoiding Unicode encoding/decoding.

A

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
AA-Turner added 2 commits April 11, 2025 05:22
@AA-Turner
Improve performance for proofread_canonicals()
56d40fa
@AA-Turner
Use bytes methods for better performance
f4bef4b
@AA-Turner
AA-Turner requested a review from hugovk April 11, 2025 04:27
hugovk
hugovk approved these changes Apr 11, 2025
View reviewed changes
@AA-Turner
AA-Turner merged commit e80b729 into main Apr 11, 2025
@AA-Turner
AA-Turner deleted the proofread-perf branch April 11, 2025 13:10
@ewdurbin ewdurbin mentioned this pull request Apr 11, 2025
plausible analytics no longer loading #265
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@AA-Turner @hugovk
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.