GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Defer import of zipp by danielhollas · Pull Request #502 · python/importlib_metadata

Conversation

@danielhollas

@danielhollas danielhollas commented Aug 27, 2024

Copy link
Copy Markdown
Contributor

Impoting zipp takes between 2-4 ms on my machine, which is at least 10% of overall import time of the importlib_metadata package (depending on Python version). Since this package is only used in a single code path it makes sense to defer it.

image

To estimate the cost of repeatedly calling import zipp I ran

❯ python -m timeit -s "import zipp"  "import zipp"
5000000 loops, best of 5: 59.9 nsec per loop

(this is with cpython main branch)

Since this is in a codepath that reads a zipfile from disk, this overhead is negligible.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@danielhollas
Defer import of zipp
76eebe0
This was referenced Aug 27, 2024
Defer import of json and platform #503
Merged
Improve import time of various stdlib modules python/cpython#118761
Closed
@jaraco

jaraco commented Sep 11, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

I'm starting to feel like a frog being slowly boiled. I'm seeing repeated optimizations like this being handled piecemeal, and each time I do, I need to go through the same process: point out that there's a systemic problem that has no solution, ensure there's a comment protecting the change and linking to the motivation, then merge and roll out the change. </rant>

Looks good. I'll add the comment linking back to the motivation and analysis (here). Thanks for the contrib.

danielhollas reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

jaraco added 2 commits September 11, 2024 09:58
@jaraco
Add comment to protect the deferred import.
d11b67f
@jaraco
Add news fragment.
e3ce33b
@jaraco
jaraco merged commit 58832f2 into python:main Sep 11, 2024
@danielhollas
danielhollas deleted the defer-zipp branch September 11, 2024 14:06
@yashuatla yashuatla mentioned this pull request Jun 22, 2025
Feature implementation from commits 2beb8b0..b34810b yashuatla/importlib_metadata#3
Open
@jaraco jaraco mentioned this pull request Oct 31, 2026
Restore the deferred imports to module scope with PEP 810 lazy imports #554
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@danielhollas @jaraco
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.