GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Deprecate legacy functions by jaraco · Pull Request #236 · python/importlib_resources

Conversation

@jaraco

@jaraco jaraco commented Oct 17, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Ref #80 (addresses the next two steps in the deprecation process).

Still to do:

  • Update tests to capture the expectation (and suppress warnings in test suite).
  • Update changelog.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
jaraco added 4 commits October 17, 2021 17:41
@jaraco
Emit deprecation warning on legacy functions.
0ad6143
@jaraco
Re-implement deprecation as a decorator.
6065e26
@jaraco
Update changelog.
13d42b7
@jaraco
Acknowledge and suppress warnings
fda6cb2
@jaraco
jaraco marked this pull request as ready for review October 17, 2021 22:10
@jaraco
jaraco requested a review from FFY00 October 17, 2021 22:12
@jaraco
Add section to the docs guiding the user on how to migrate (relying o…
ed3b2d3
…n the _legacy module as a guide because it's so easy to read).
FFY00
FFY00 approved these changes Oct 17, 2021
View reviewed changes

@FFY00 FFY00 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread importlib_resources/_legacy.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread docs/using.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

@jaraco
Provide references to relevant docs and protocol definition for ease-…
239ae6d
…of-use.
@jaraco
jaraco merged commit 8ac7ab5 into main Oct 18, 2021
@jaraco
jaraco deleted the feature/deprecate-legacy branch October 18, 2021 17:55
@jaraco jaraco mentioned this pull request Oct 18, 2021
Deprecate legacy API in favor of traversable API (files) #80
Closed
8 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FFY00 FFY00 FFY00 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@jaraco @FFY00
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.