GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Replace tests of legacy API with comparable tests of traversable API. by jaraco · Pull Request #239 · python/importlib_resources

Conversation

@jaraco

@jaraco jaraco commented Oct 22, 2021

Copy link
Copy Markdown
Member
  • Port test_contents to files API
  • Remove tests for relative/absolute paths, no longer relevant. Move normalize_path to _legacy.
  • Port test_open to traversable API.
  • Port test_path to traversable API.
  • Port test_read to traversable API.
  • Port test_resource to traversable API.
  • Remove 'suppress_known_deprecation' helper.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
jaraco added 4 commits October 21, 2021 21:31
@jaraco
Port test_contents to files API
c0a186d
@jaraco
Remove tests for relative/absolute paths, no longer relevant. Move no…
bba97e5 
…rmalize_path to _legacy.
@jaraco
Port test_open to traversable API.
eda56b3
@jaraco
Port test_path to traversable API.
d87a8dd
@jaraco
jaraco force-pushed the feature/test-no-legacy branch from 6c49e83 to 3bf9fc8 Compare October 22, 2021 02:41
@jaraco jaraco mentioned this pull request Oct 22, 2021
Deprecate legacy API in favor of traversable API (files) #80
Closed
8 tasks done
@jaraco
jaraco force-pushed the feature/test-no-legacy branch 4 times, most recently from b209467 to 634dc00 Compare October 22, 2021 02:58
@jaraco
Port test_read to traversable API.
6f35cd3
@jaraco
jaraco force-pushed the feature/test-no-legacy branch from 634dc00 to dbb4ca3 Compare October 22, 2021 03:00
jaraco added 3 commits October 21, 2021 23:02
@jaraco
Port test_resource to traversable API.
797c097
@jaraco
Remove 'suppress_known_deprecation' helper.
dfe87a6
@jaraco
Exclude legacy from coverage.
5869cf3
@jaraco
jaraco force-pushed the feature/test-no-legacy branch from dbb4ca3 to 5869cf3 Compare October 22, 2021 03:02
@jaraco
Update changelog.
15073ca
@jaraco
jaraco merged commit bc6f0d1 into main Oct 30, 2021
@jaraco
jaraco deleted the feature/test-no-legacy branch October 30, 2021 14:28
@FFY00 FFY00 mentioned this pull request Dec 1, 2024
importlib.resources regression for custom ResourceReader python/cpython#127337
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@jaraco
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.