GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Re-use joinpath logic in Traversable and MultiplexedPath by jaraco · Pull Request #250 · python/importlib_resources

Conversation

@jaraco

@jaraco jaraco commented Apr 17, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Inspired by #248 (comment)

  • Inline the flattening of descendants.
  • Move ResourceContainer.joinpath to Traversable.joinpath, providing a concrete implementation.
  • Refactor to converge descendants to a single type and rely on Path.parts for getting the parts.
  • Replace StopIteration with a TraversalError for use in capturing a failed traversal.
  • In readers.MultiplexedPath, re-use Traversable.joinpath.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jaraco jaraco mentioned this pull request Apr 18, 2022
bpo-47142: Refine Traversable. #248
Merged
FFY00
FFY00 approved these changes Apr 18, 2022
View reviewed changes

@FFY00 FFY00 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had the look at the PR and it seems good. Thank you for splitting each logical change into its own commit.

I only have one note.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread importlib_resources/abc.py
try:
return next(matches).joinpath(*names)
except StopIteration:
raise TraversalError(

@FFY00 FFY00 Apr 18, 2022

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only way for this to happen is no arguments being passed, no? Wouldn't checking for that directly make the code easier to read?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@jaraco jaraco Jun 13, 2022

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that's correct. A StopIteration would occur if none of the traversable.name == target in the matches above (including if self.iterdir() yields no results). It's trapping StopIteration on next(matches), not *names. *names can be empty. Maybe only the exception should be trapped for next(matches).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@FFY00 FFY00 Jun 13, 2022

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, right, that makes sense.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
jaraco
jaraco commented Jun 13, 2022
View reviewed changes
Comment thread importlib_resources/abc.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@jaraco jaraco mentioned this pull request Jun 16, 2022
Better docs for importlib.resources python/cpython#93610
Closed
jaraco added 9 commits June 15, 2022 21:00
@jaraco
Inline the flattening of descendants.
e396423
@jaraco
Move ResourceContainer.joinpath to Traversable.joinpath, providing a …
df36958 
…concrete implementation.
@jaraco
Refactor to converge descendants to a single type and rely on Path.pa…
b923ce2 
…rts for getting the parts.
@jaraco
Replace StopIteration with a TraversalError for use in capturing a fa…
c3cefa6 
…iled traversal.
@jaraco
In readers.MultiplexedPath, re-use Traversable.joinpath.
6440323
@jaraco
Add test for empty joinpath.
075b6ce
@jaraco
Leave this behavior uncovered.
0140430
@jaraco
Separate match resolution from recursive join.
643caba
@jaraco
Update changelog
1def9a2
@jaraco
jaraco force-pushed the bugfix/MultiplexedPath-descendants branch from 779f59e to 1def9a2 Compare June 16, 2022 01:01
@jaraco
jaraco merged commit acfc5c9 into main Jun 16, 2022
@jaraco
jaraco deleted the bugfix/MultiplexedPath-descendants branch June 16, 2022 01:06
@jaraco jaraco mentioned this pull request Jul 3, 2022
TraversalError in MultiplexedPath.joinpath when parent in compound path is missing #253
Closed
@VolkerH VolkerH mentioned this pull request Aug 17, 2022
Possible bug introduced with PR250, joinpath with "." causes StopIteration #263
Closed
@jaraco jaraco mentioned this pull request Jul 11, 2023
Possible regression in MultiplexedPath.joinpath in 3.12 python/cpython#106614
Closed
@Zhuyuyangyy Zhuyuyangyy mentioned this pull request Oct 30, 2026
Fix SimpleReader traversal adapters #339
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FFY00 FFY00 FFY00 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@jaraco @FFY00
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.