GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Stubtest: add some hacks so that `sys.monitoring` is checked in typeshed's CI by AlexWaygood · Pull Request #16269 · python/mypy

Conversation

@AlexWaygood

@AlexWaygood AlexWaygood commented Oct 15, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Currently, in typeshed's CI, stubtest isn't detecting that sys.monitoring is missing from typeshed. Even if you add sys.monitoring stubs to typeshed, stubtest doesn't verify that any of the details about sys.monitoring are correct, since sys.monitoring is somewhat unique: it's a genuine instance of types.ModuleType in the global namespace of the sys module, but import sys.monitoring will fail at runtime (sys isn't a package).

I verified locally that these changes cause stubtest to start complaining about sys.monitoring being missing with typeshed's current setup; and, if python/typeshed#10890 were merged, these changes here would cause stubtest to start complaining if there were any inaccuracies between the runtime and the stubs for sys.monitoring

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@AlexWaygood
Stubtest: add some hacks so that sys.monitoring is checked in types…
2402a12
…hed's CI
@AlexWaygood
AlexWaygood requested a review from hauntsaninja October 15, 2023 23:07
@sobolevn

sobolevn commented Oct 16, 2023

Copy link
Copy Markdown
Member

I would propose changing this in CPython :(

AlexWaygood reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@AlexWaygood

AlexWaygood commented Oct 16, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

I would propose changing this in CPython :(

It's not the design I would have chosen, for sure. There was discussion on this in the original PR that implemented the feature: python/cpython#103083 (comment)

Perhaps Mark would be receptive to this being changed, reading through the comments again. I'm not sure.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@AlexWaygood AlexWaygood mentioned this pull request Nov 29, 2023
Add sys.monitoring from Python 3.12 python/typeshed#10890
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hauntsaninja hauntsaninja Awaiting requested review from hauntsaninja

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@AlexWaygood @sobolevn
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.