GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [mypyc] Only track registers in must-defined analysis by Jahongir-Qurbonov · Pull Request #22425 · python/mypy

Conversation

@Jahongir-Qurbonov

@Jahongir-Qurbonov Jahongir-Qurbonov commented Nov 10, 2026

Copy link
Copy Markdown
Contributor

The refcount and uninit transforms pass all values, including temporaries, as the universe of the must-defined analysis (analyze_must_defined_regs). DefinedVisitor only generates and kills registers, and both callers only check registers (is_maybe_undefined in refcount, split_blocks_at_uninits in uninit), so the temporaries are never needed. However, a must analysis starts with a copy of the universe for every basic block, so time and memory were O(blocks * values).

This makes the refcount transform very slow for large functions, such as generated code or long module top levels. Benchmark: a function with n statements of the form

    a{i} = xs[{i % 7}] + {i}
    if a{i}:
        t = a{i}

timing insert_ref_count_opcodes alone (max RSS of the process):

n ops blocks master this PR
1000 9k 4k 0.86s, 1.2 GiB 0.33s, 0.27 GiB
2000 18k 8k 3.8s, 4.7 GiB 1.8s, 1.1 GiB
4000 36k 16k ~110s, 15 GiB 6.2s, 3.3 GiB

Fix: leave everything except registers out of the universe. The analysis results for registers are the same, so the output doesn't change:

  • The generated IR for the benchmark functions is identical.
  • The generated C for mypy/checker.py, mypy/checkexpr.py, mypy/semanal.py and mypy/messages.py (29 MB) is identical to master.

For typical functions the gain is small (must-defined analysis on those four modules: 1.28s -> 1.14s), since they are short.

The remaining cost for large functions is still superlinear, because the must-defined sets contain O(registers) items per block and run_analysis builds a new set for every op. Using bitsets could fix that, but it's a bigger change, so I left it out of this PR.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@Jahongir-Qurbonov
[mypyc] Only track registers in must-defined analysis
7603a3a
The refcount and uninit transforms pass all values, including
temporaries, as the universe of the must-defined analysis. The analysis
only generates and kills registers, and the callers only check
registers, so the temporaries are never needed. However, a must
analysis starts with a copy of the universe for every basic block, so
time and memory used were O(blocks * values).

This made the refcount transform very slow for large functions. For a
function with 4000 statements (36k ops, 16k blocks), it took ~110s and
used 15 GiB of memory. Now it takes 6s and uses 3.3 GiB.

Leave everything except registers out of the universe. The generated
IR and C are unchanged.
@Jahongir-Qurbonov Jahongir-Qurbonov mentioned this pull request Nov 10, 2026
[mypyc] Use bitsets in data-flow analyses #22426
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@Jahongir-Qurbonov
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.