GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||||||||
GeezerVison is showing github.com — [mypyc] Only track registers in must-defined analysis by Jahongir-Qurbonov · Pull Request #22425 · python/mypy Conversation
Contributor
The refcount and uninit transforms pass all values, including temporaries, as the universe of the must-defined analysis ( This makes the refcount transform very slow for large functions, such as generated code or long module top levels. Benchmark: a function with n statements of the form a{i} = xs[{i % 7}] + {i} if a{i}: t = a{i} timing
Fix: leave everything except registers out of the universe. The analysis results for registers are the same, so the output doesn't change:
For typical functions the gain is small (must-defined analysis on those four modules: 1.28s -> 1.14s), since they are short. The remaining cost for large functions is still superlinear, because the must-defined sets contain O(registers) items per block and
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsThe refcount and uninit transforms pass all values, including temporaries, as the universe of the must-defined analysis. The analysis only generates and kills registers, and the callers only check registers, so the temporaries are never needed. However, a must analysis starts with a copy of the universe for every basic block, so time and memory used were O(blocks * values). This made the refcount transform very slow for large functions. For a function with 4000 statements (36k ops, 16k blocks), it took ~110s and used 15 GiB of memory. Now it takes 6s and uses 3.3 GiB. Leave everything except registers out of the universe. The generated IR and C are unchanged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersNo reviewsUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | ||||||||||||||||||||
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |