GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix metaclass dispatch ordering for class-object operators by Johnx-w · Pull Request #22444 · python/mypy

Conversation

@Johnx-w

@Johnx-w Johnx-w commented Nov 12, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Fixes #22377

Summary

Use the runtime metaclasses of class-object operands when deciding reflected-operator priority, while preserving the original operand types for checking the method calls. This also covers operands annotated with type[...] and bounded type variables.

 check_op_reversible
- order class-object operators using constructor types or TypeType wrappers
+ order class-object operators using their runtime metaclasses

The regression test covers overridden and inherited reflected methods, unrelated and identical metaclasses, class objects, and typed parameters.

Evidence

On master 332915e, the new regression test fails; with this change, it passes.

  • Related class, expression, overload, generic, and protocol suites: 1502 passed, 4 skipped, 1 xfailed.
  • Self-check: no issues in 349 source files.
  • Black, Ruff, and git diff --check: passed.

Merge Danger

Door: two-way. Blast radius: inferred binary-operator results for class-object operands.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Johnx-w added 2 commits November 12, 2026 09:25
@Johnx-w
Fix metaclass dispatch ordering for class-object operators
93c1dd2
@Johnx-w
Add class-object operator dispatch regression tests
16204fc
@github-actions

github-actions Bot commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

binary operator on class objects ignores the right operand's reflected method when its metaclass subclasses the left operand's metaclass

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@Johnx-w
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.