GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — PEP 612: Clean up code examples, link to CPython implementation by Fidget-Spinner · Pull Request #1745 · python/peps

Conversation

@Fidget-Spinner

@Fidget-Spinner Fidget-Spinner commented Dec 24, 2020

Copy link
Copy Markdown
Member

An unused variable was removed from the code example.

I also added a line to point to the CPython implementation for posterity.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Fidget-Spinner
Remove unused var, link to CPython implementation
832a03e
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Dec 24, 2020
@gvanrossum

gvanrossum commented Dec 24, 2020

Copy link
Copy Markdown
Member

Can you also fix the typo on line 302?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Fidget-Spinner
fix typevar typo
c2ba65b
@Fidget-Spinner Fidget-Spinner changed the title PEP 612: Remove unused var, link to CPython implementation PEP 612: Clean up code examples, link to CPython implementation Dec 24, 2020
gvanrossum
gvanrossum approved these changes Dec 24, 2020
View reviewed changes
@gvanrossum
gvanrossum merged commit 08f7e0e into python:master Dec 24, 2020
@Fidget-Spinner
Fidget-Spinner deleted the patch-1 branch December 24, 2020 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

CLA signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@Fidget-Spinner @gvanrossum @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.