GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — PEP 646: Add some broader context by mrahtz · Pull Request #1904 · python/peps

Conversation

@mrahtz

@mrahtz mrahtz commented Mar 31, 2021

Copy link
Copy Markdown
Contributor

These sections were requested in some feedback we got when talking to NumPy and JAX folks. OK, this does make an already-long PEP even longer, but I do think this context is important - especially for folks who don't have strong intuitions for how parametric typing works in Python.

This is just a draft right now, but I'll submit a PR to get some early feedback from Python folks while I also check with external folks whether this makes sense.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mrahtz
PEP 646: Add some broader context
d793717 
These sections were requested in some feedback we got when talking to NumPy and JAX folks. OK, this does make an already-long PEP even longer, but I do think this context is important - especially for folks who don't have strong intuitions for how parametric typing works in Python.
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Mar 31, 2021
@mrahtz
PEP 646: Fix typo
8246260 
Thank god for linters
@mrahtz

mrahtz commented Mar 31, 2021

Copy link
Copy Markdown
Contributor Author

@pradeep90 Have I fairly reflected your opinions on this stuff in this section? Any tweaks you want made?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
shoyer
shoyer reviewed Apr 1, 2021
View reviewed changes
Comment thread pep-0646.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread pep-0646.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread pep-0646.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread pep-0646.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@mrahtz
PEP 646: Add more detail on 'names as types' vs 'names as values'
4522ee2
@gvanrossum

gvanrossum commented Apr 1, 2021 via email

Copy link
Copy Markdown
Member
@mrahtz please let me know when you're ready for me to merge this. I won't have time to review it thoroughly myself, but I can merge it when you say you're ready.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
alextp
alextp reviewed Apr 1, 2021
View reviewed changes
Comment thread pep-0646.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@brettcannon
brettcannon requested a review from gvanrossum April 1, 2021 19:39
pradeep90
pradeep90 reviewed Apr 6, 2021
View reviewed changes
Comment thread pep-0646.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread pep-0646.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread pep-0646.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread pep-0646.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
mrahtz added 2 commits April 6, 2021 21:27
@mrahtz
PEP 646: Fix typos
fd5178c
@mrahtz
PEP 646: Rewrite extra context sections
b70b3e0
shoyer
shoyer approved these changes Apr 10, 2021
View reviewed changes
Comment thread pep-0646.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@mrahtz
PEP 646: Add Stephan's suggested syntex for named tensors
a184085
pradeep90
pradeep90 reviewed Apr 11, 2021
View reviewed changes
Comment thread pep-0646.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
pradeep90
pradeep90 reviewed Apr 11, 2021
View reviewed changes
Comment thread pep-0646.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@rsokl rsokl mentioned this pull request Apr 12, 2021
Support functions in tensor shapes. patrick-kidger/torchtyping#2
Open
@mrahtz @pradeep90
PEP 646: Fix typo
257af3c 
Co-authored-by: Pradeep Kumar <[email protected]>
shoyer
shoyer reviewed Apr 12, 2021
View reviewed changes
Comment thread pep-0646.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@gvanrossum gvanrossum mentioned this pull request Apr 12, 2021
Submission for SC consideration: PEP 646 -- Variadic Generics python/steering-council#59
Closed
@mrahtz
PEP 646: Fix the named-tensors-through-types example
d142b09
@mrahtz

mrahtz commented Apr 18, 2021

Copy link
Copy Markdown
Contributor Author

@gvanrossum I think this is ready to merge now.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gvanrossum
gvanrossum merged commit 5578160 into python:master Apr 18, 2021
@mrahtz
mrahtz deleted the patch-1 branch August 22, 2021 18:03
@erlend-aasland erlend-aasland mentioned this pull request May 13, 2022
pep8/greppable exception messages erlend-aasland/peps#1
Closed
@erlend-aasland erlend-aasland mentioned this pull request Jun 27, 2022
pep 687/mark as accepted erlend-aasland/peps#2
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum Awaiting requested review from gvanrossum
3 more reviewers
@alextp alextp alextp left review comments
@pradeep90 pradeep90 pradeep90 left review comments
@shoyer shoyer shoyer approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

CLA signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@mrahtz @gvanrossum @alextp @pradeep90 @shoyer @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.