GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||||||||||||||
GeezerVison is showing github.com — PEP 678: more rejected ideas by Zac-HD · Pull Request #2205 · python/peps Conversation
Contributor
I've added a few sections addressing rejected ideas from this discussion on Reddit, and laid out my position about non- My own design intuition is pretty clearly against non-string notes... but my respect for the voice of experience is also strong. This draft of the PEP therefore describes the current implementation (string-or-None), but I'm open to revising that based on python-dev discussion (planning to post early in the new year).
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
iritkatriel
reviewed
Uh oh!
There was an error while loading. Please reload this page.
gvanrossum
reviewed
Uh oh!
There was an error while loading. Please reload this page. Uh oh!
There was an error while loading. Please reload this page. Uh oh!
There was an error while loading. Please reload this page.
Member
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Zac-HD
force-pushed
the
exception-note
branch
from
9a118c2 to
d95f7d9
Compare
Contributor
Author
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
iritkatriel
reviewed
Uh oh!
There was an error while loading. Please reload this page.
iritkatriel
reviewed
Uh oh!
There was an error while loading. Please reload this page.
iritkatriel
reviewed
Uh oh!
There was an error while loading. Please reload this page.
AA-Turner
requested changes
|
| Store notes in ``ExceptionGroup`` s | ||
| ----------------------------------- |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Similar to above, if the space is required please could you escape it
| Store notes in ``ExceptionGroup`` s | |
| ----------------------------------- | |
| Store notes in ``ExceptionGroup``\ s | |
| ------------------------------------ |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
A few minor syntax fixes and a question for clarification
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
I imagine the SC will appreciate this being submitted ahead of the PEP rush leading up to the feature freeze. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
25ab9cd to
ab1ca0f
Compare
ab1ca0f to
1b7442c
Compare
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@AA-Turner @CAM-Gerlach Any further comments?
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Noticed two typos, I'll just commit the fixes
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Sorry I didn't get a chance to re-review -- looks good though, thanks @Zac-HD & @iritkatriel! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@AA-Turner Thank you for your review. I went ahead and merged so @Zac-HD can post it, but it's still a draft so we can fix things in future PRs. Let us know if you see anything. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Looks good as well, thanks! Per #2130 , you could consider converting the references from footnotes to actual link targets and just directly linking the appropriate text in the body (aside from the one that is an actual footnotes), to make them much easier to follow for readers. E.g. .. _breakage without warning: https://example.com Or, you could give the link target a short name instead, e.g. But, to be clear, you don't have to do that if you don't want, if you feel it creates too much churn. Or I'm happy to open a PR for you. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
🙏 Thanks so much to everyone for you feedback and fixes - the document is so much better than it would be without you! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@CAM-Gerlach - I've really just imitated other PEPs here; my impression is that the use of footnotes is mostly for ease of reading in e.g. mail clients which don't support HTML or RST markup. That does seem like more of a historical concern, but I'm hesitant to break with tradition in my first PEP 😅 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
I think ease of reading on the web is far more important -- a lot of recent edits to various PEPs have included inlining links. Appreciate the concerns, though! A |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.