GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Set low priority for rm-ing refs section so refs still resolve correctly by CAM-Gerlach · Pull Request #2227 · python/peps

Conversation

@CAM-Gerlach

@CAM-Gerlach CAM-Gerlach commented Jan 12, 2022

Copy link
Copy Markdown
Member

As a followup to #2155 (and thus related to #2130 ), this sets a low priority to removing the references section, to fix link references not resolving for some cases on the legacy build system (pep2html.py) where the references section gets removed if it would render empty, as apparently otherwise it is removed before it is needed to resolve the refs. Not sure how I didn't catch those cases in testing, but this simple tweak fixes it. Since this breaks proper link resolution on certain PEPs (at least those using multi-layer reference indirection, like PEP 639) and fixes a regression, it would be appreciated to merge this promptly. Sorry for not spotting this earlier!

CC: @AA-Turner

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@CAM-Gerlach
Set low priority for rm-ing refs section so refs still resolve correctly
8995458
@CAM-Gerlach
CAM-Gerlach requested a review from a team as a code owner January 12, 2022 00:41
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jan 12, 2022
JelleZijlstra
JelleZijlstra approved these changes Jan 12, 2022
View reviewed changes
@JelleZijlstra
JelleZijlstra merged commit c33b724 into python:main Jan 12, 2022
@CAM-Gerlach
CAM-Gerlach deleted the fix-refs-legacy-build branch January 12, 2022 01:24
@CAM-Gerlach CAM-Gerlach mentioned this pull request Jan 12, 2022
Fix refs section removal breaking external links on Sphinx build too #2229
Merged
@CAM-Gerlach CAM-Gerlach mentioned this pull request Feb 4, 2022
PEP 12: Recommend and explain native RST hyperlinks (versus footnotes) #2302
Merged
@erlend-aasland erlend-aasland mentioned this pull request May 13, 2022
pep8/greppable exception messages erlend-aasland/peps#1
Closed
@erlend-aasland erlend-aasland mentioned this pull request Jun 27, 2022
pep 687/mark as accepted erlend-aasland/peps#2
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

CLA signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@CAM-Gerlach @JelleZijlstra @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.