GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||
GeezerVison is showing github.com — PEP 594: Apply typofixes & language tweaks by bskinn · Pull Request #2334 · python/peps ConversationJust a few things I noticed on my read-through.
CAM-Gerlach
reviewed
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. A few minor further tweaks, otherwise LGTM. Thanks @bskinn !
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsUh oh!
There was an error while loading. Please reload this page. Uh oh!
There was an error while loading. Please reload this page. Uh oh!
There was an error while loading. Please reload this page. Adds two missing commas and rewords the 'these packages are no longer slated for deprecation' language -- thanks, @CAM-Gerlach! Co-authored-by: CAM Gerlach <[email protected]> Uh oh!
There was an error while loading. Please reload this page.
Member
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Contributor
Author
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. - Harmonize header capitalization - Add ``parser`` code formatting - Add whitespacelines under "Update #" headers for consistency.
Member
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Contributor
Author
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Member
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Contributor
Author
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
CAM-Gerlach
approved these changes
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. LGTM now, thanks @bskinn !
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
|
There was an error while loading. Please reload this page.
|
@brettcannon I assume you'll want to look this over and merge, since this is your PEP? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@CAM-Gerlach 🤷 there's no semantic change here, so no need to wait on me specifically. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@bskinn thanks for the PR! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.