GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add optional Connection.autocommit attribute to PEP 249 by malemburg · Pull Request #2887 · python/peps

Conversation

@malemburg

@malemburg malemburg commented Nov 16, 2022

Copy link
Copy Markdown
Member

As discussed on the DB-SIG ML.

Fix the creation date to point to the announcement date of the DB-API 2.0.

Add years to the acknowledgements.

Minor editorial changes.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland reacted with hooray emoji
All reactions
  • 🎉 1 reaction
@malemburg
Add optional Connection.autocommit attribute as discussed on the DB-S…
c2ec0fa 
…IG ML.

Fix the creation date to point to the announcement date of the
DB-API 2.0.

Add years to the acknowledgements.

Minor editorial changes.
@malemburg
malemburg requested a review from erlend-aasland November 16, 2022 14:31
erlend-aasland
erlend-aasland reviewed Nov 16, 2022
View reviewed changes
Comment thread pep-0249.txt Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread pep-0249.txt Resolved

Uh oh!

There was an error while loading. Please reload this page.
malemburg added 2 commits November 16, 2022 16:13
@malemburg
Fix spelling.
51228dc
@malemburg
Fix another spelling mistake.
534ca06
@malemburg

malemburg commented Nov 16, 2022

Copy link
Copy Markdown
Member Author

Thanks for the review, @erlend-aasland
erlend-aasland reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland
erlend-aasland approved these changes Nov 16, 2022
View reviewed changes

@erlend-aasland erlend-aasland left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PEP update, Marc-André! LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@malemburg
malemburg merged commit 74e6056 into python:main Nov 16, 2022
@erlend-aasland erlend-aasland mentioned this pull request Nov 16, 2022
Add an autocommit property to sqlite3.Connection with a PEP 249 compliant manual commit mode and migrate python/cpython#83638
Closed
CAM-Gerlach
CAM-Gerlach reviewed Nov 17, 2022
View reviewed changes
Comment thread pep-0249.txt
@@ -5,7 +5,7 @@ Discussions-To: [email protected]
Status: Final

@CAM-Gerlach CAM-Gerlach Nov 17, 2022

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this PEP is Informational, shouldn't it be Active, givens the guidance within is presumably still valid, up to date and in-use rather than historical and frozen?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CAM-Gerlach CAM-Gerlach CAM-Gerlach left review comments
@erlend-aasland erlend-aasland erlend-aasland approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@malemburg @erlend-aasland @CAM-Gerlach
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.