GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — PEP 562: Fix example by adding repr in an error message by ezio-melotti · Pull Request #2928 · python/peps

Conversation

@ezio-melotti

@ezio-melotti ezio-melotti commented Dec 16, 2022

Copy link
Copy Markdown
Member

The first example in the PEP doesn't use !r while formatting the name of the module and the attribute. The following example does. This PR fixes the first example so that it matches the second and the regular behavior of Python while trying to access a non-existing module variable.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ezio-melotti
Fix example by adding repr in an error message.
500c178
@ezio-melotti ezio-melotti added the enhancement label Dec 16, 2022
@ezio-melotti
ezio-melotti requested a review from ilevkivskyi as a code owner December 16, 2022 17:30
@CAM-Gerlach CAM-Gerlach changed the title PEP 562: Fix example by adding repr in an error message. PEP 562: Fix example by adding repr in an error message Dec 16, 2022
@CAM-Gerlach CAM-Gerlach added bug and removed enhancement labels Dec 16, 2022
CAM-Gerlach
CAM-Gerlach approved these changes Dec 16, 2022
View reviewed changes

@CAM-Gerlach CAM-Gerlach left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM at least as far as I'm concerned, this looks like a straightforward typo error in examples of the form we've usually merged before, and this very much isn't a drive-by trivial contributor here, so it seems worth it to me to just merge this, so long as the PR author doesn't object.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@CAM-Gerlach

CAM-Gerlach commented Dec 16, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Also, to note, this PR's feature branch was created on the upstream repo instead of the author's fork, which will block final implementation of the remaining step of python/core-workflow#460 until it is merged or closed, so hopefully it can be resolved quickly 🙂
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Rosuav

Rosuav commented Dec 16, 2022

Copy link
Copy Markdown
Contributor

No objections here.
CAM-Gerlach reacted with thumbs up emoji ezio-melotti reacted with hooray emoji
All reactions
  • 👍 1 reaction
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@CAM-Gerlach CAM-Gerlach mentioned this pull request Dec 16, 2022
Adjusting the "Triager" role's permissions python/core-workflow#460
Closed
@JelleZijlstra
JelleZijlstra merged commit 89ed2e4 into main Dec 16, 2022
@JelleZijlstra
JelleZijlstra deleted the pep562-repr-example branch December 16, 2022 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CAM-Gerlach CAM-Gerlach CAM-Gerlach approved these changes
@ilevkivskyi ilevkivskyi Awaiting requested review from ilevkivskyi

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@ezio-melotti @CAM-Gerlach @Rosuav @JelleZijlstra
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.