GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — PEP 738: Android support, draft 2 by mhsmith · Pull Request #3651 · python/peps

Conversation

@mhsmith

@mhsmith mhsmith commented Feb 8, 2024 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Change is either:
    • To a Draft PEP
    • To an Accepted or Final PEP, with Steering Council approval
    • To fix an editorial issue (markup, typo, link, header, etc)
  • PR title prefixed with PEP number (e.g. PEP 123: Summary of changes)

Updates following discussion on Discourse:

  • Reduce minimum Android API level from 23 to 21.
  • Add more device information fields to platform.android_ver.

Other changes:

  • State that a python3.x executable will not be officially supported on this platform. For the reasons explained in "App lifecycle", this would be of very little use.
  • Add another reason why libpython must be dynamically linked.
  • Add details of stdin, stdout, and stderr.
  • Remove spwd from unsupported modules list, since it's already been removed from Python 3.13.

@freakboy3742: FYI


📚 Documentation preview 📚: https://pep-previews--3651.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@mhsmith
PEP 738: updates following discussion
531fc3f
@mhsmith
mhsmith requested a review from encukou as a code owner February 8, 2024 16:26
@mhsmith mhsmith mentioned this pull request Feb 8, 2024
android: add platform.android_ver() python/cpython#71042
Closed
hugovk
hugovk reviewed Feb 8, 2024
View reviewed changes

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, a couple of comments about accessibility.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread peps/pep-0738.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread peps/pep-0738.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

freakboy3742
freakboy3742 previously requested changes Feb 8, 2024
View reviewed changes

@freakboy3742 freakboy3742 left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A good set of improvements and clarifications; a couple of minor nits/questions inline.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread peps/pep-0738.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread peps/pep-0738.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread peps/pep-0738.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

mhsmith added 2 commits February 9, 2024 13:51
@mhsmith
Minor wording updates
2735873
@mhsmith
Remove manual list spacers
1297b19
@encukou
encukou dismissed freakboy3742’s stale review February 13, 2024 15:16

The comments were resolved.

@encukou
encukou merged commit fda02b5 into python:main Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk left review comments
@freakboy3742 freakboy3742 freakboy3742 left review comments
@encukou encukou Awaiting requested review from encukou encukou is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@mhsmith @freakboy3742 @hugovk @encukou
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.