GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — PEP 394: Allow for more flexibility in handling /usr/bin/python by hroncok · Pull Request #989 · python/peps

Conversation

@hroncok

@hroncok hroncok commented Apr 12, 2019

Copy link
Copy Markdown
Contributor

Co-Authored-By: @encukou

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@hroncok @encukou
PEP 394: Distributions can choose what does python mean
68475c0
Co-Authored-By: Petr Viktorin <[email protected]>
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Apr 12, 2019
@hroncok hroncok mentioned this pull request Apr 12, 2019
PEP 394: Distributions can choose what does python mean fedora-python/peps#1
Closed
@brettcannon
brettcannon requested a review from encukou April 12, 2019 17:23
warsaw
warsaw reviewed Apr 12, 2019
View reviewed changes
Comment thread pep-0394.txt Resolved

Uh oh!

There was an error while loading. Please reload this page.

@hroncok
fixup! PEP 394: Distributions can choose what does python mean
abf3bf3
@encukou
encukou requested a review from ncoghlan April 15, 2019 10:22
ncoghlan
ncoghlan reviewed Apr 15, 2019
View reviewed changes

@ncoghlan ncoghlan left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The proposed change looks good to me in general, some minor wording suggestions and one more substantial adjustment inline.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread pep-0394.txt Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread pep-0394.txt Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread pep-0394.txt Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread pep-0394.txt Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread pep-0394.txt Resolved

Uh oh!

There was an error while loading. Please reload this page.

hroncok added 2 commits April 15, 2019 18:13
@hroncok
fixup! PEP 394: Distributions can choose what does python mean
4a4cdf7
@hroncok
fixup! PEP 394: Distributions can choose what does python mean
36e61fa
encukou
encukou reviewed Apr 24, 2019
View reviewed changes

@encukou encukou left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As co-author, I agree with the change, but I don't think I should be the reviewer :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@gvanrossum

gvanrossum commented Apr 24, 2019

Copy link
Copy Markdown
Member

You should probably get the Steering Council to appoint a BDFL-Delegate who can approve it. Last time we had MvL as PEP Czar but he's not around, and BDFL-Delegate is the closest thing. I'm not touching this myself. :-)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@encukou encukou mentioned this pull request Apr 24, 2019
PEP 394: Change review request python/steering-council#8
Closed
@encukou

encukou commented Apr 24, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Thanks for the advice! Just before I read your comment, I asked for, essentially, just that :)
python/steering-council#8

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@warsaw

warsaw commented Apr 24, 2019

Copy link
Copy Markdown
Member

Since Nick, Petr, and myself are all authors, who would we get to be a BD?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@gvanrossum

gvanrossum commented Apr 24, 2019 via email

Copy link
Copy Markdown
Member
The SC could deliberate it for a bit during our next meeting.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ncoghlan ncoghlan changed the title PEP 394: Distributions can choose what does python mean PEP 394: Allow for more flexibility in handling /usr/bin/python Apr 25, 2019
@ncoghlan

ncoghlan commented Apr 25, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Definitely an SC level discussion (and it probably makes sense for us to just review the PR changes directly).

Some potentially useful context for that discussion:

  • https://fedoraproject.org/wiki/Changes/Mass_Python_2_Package_Removal (Fedora 30 is feature complete and will be released in the next few weeks)
  • https://fedoraproject.org/wiki/Changes/F31_Mass_Python_2_Package_Removal (Fedora 31 is scheduled to be released in October)
  • https://fedoraproject.org/wiki/Changes/RetirePython2 (Fedora 32 doesn't have a final schedule yet, but late April/early May is the usual time frame - the key point for our purposes is that it will be the first Fedora release after Python 2 goes completely end of life upstream)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ncoghlan ncoghlan mentioned this pull request Apr 25, 2019
[WIP] PEP 394: Allow not installing unversioned "python" command #893
Closed
@hroncok

hroncok commented Apr 25, 2019

Copy link
Copy Markdown
Contributor Author

To complete the list of Fedora changes posted by Nick:

My idea is to also include a Fedora 31 change that moves /usr/bin/python (and others, such as nose, pytest, pip) to Python 3 (with possible deferral to F32), together with package provides (dnf install python to install Python 3, dnf install python-requests to install python3-requests). I just haven't drafted it yet, waiting for the resolution of this PEP update.

https://fedoraproject.org/wiki/FinalizingFedoraSwitchtoPython3#Phase_3:_Switch_python_to_refer_to_python3

ncoghlan reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ncoghlan
ncoghlan requested changes Apr 25, 2019
View reviewed changes
Comment thread pep-0394.txt Resolved

Uh oh!

There was an error while loading. Please reload this page.

@ncoghlan

ncoghlan commented Apr 25, 2019

Copy link
Copy Markdown
Contributor

@hroncok Ah, nice! I think that would tie in better with my proposed guidance then, as once you've implemented that change, then /usr/bin/env python shebangs will start working on Python 3 only Fedora systems, just as they'd work on RHEL 8 systems where an admin has run alternatives --set python /usr/bin/python3 (as per https://developers.redhat.com/blog/2018/11/14/python-in-rhel-8/)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@encukou

encukou commented Apr 25, 2019

Copy link
Copy Markdown
Member

About setting /usr/bin/python, that article says:

Note, We do not recommend this approach. We recommend you explicitly refer to python3 or python2. That way, your scripts and commands will work on any machine that has the right version of Python installed.

I still think that is good advice. Setting /usr/bin/python is a decision of the sysadmin, not the user, and it's machine-global – if anything on the machine grows to depend on the decision, it practically can't be changed.
Generic scripts are better off using python3.

Keep in mind this PEP's advice will be applied to new code. New code generally won't be deployed on systems without a python3 command. Not having python3 signalizes an old system with a high cost of upgrading (not only the system, but also software on it).

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ncoghlan

ncoghlan commented Apr 26, 2019

Copy link
Copy Markdown
Contributor

I don't think always using "/usr/bin/python3" is generically good advice for new code, since I think requiring the python3 spelling is ultimately a transient thing - I expect most distros to follow Fedora's approach, and make python refer to python3 by default once they drop their full Python 2 stacks, and I expect we'll eventually change the Windows launcher to at least fall back to Python 3 for unqualified shebang lines, and potentially even prefer it over Python 2.7 once the latter goes end-of-life.

So I think it's entirely reasonable for publishers to continue to use "/usr/bin/env python" as their default approach, and tell anyone with a system where that doesn't work to either:

  1. Use an appropriately configured virtual environment; or
  2. Set up a shell alias or user level symlink so it works for their personal account; or
  3. Convince the system administrators to make it work by default across the entire machine; or
  4. Edit the shebang line to be correct for their system before running the script (if editing a shebang line is problematic, folks should be using installers, not downloading scripts directly)

While specifying /usr/bin/env python3 instead is an entirely reasonable alternative, that offers some potential benefits and is hence well worth mentioning, that's a far cry from telling all current publishers "Your script shebang lines are now wrong, and you should change them" (or, even more irritatingly, encouraging folks to go around submitting PRs to open source projects along the lines of "PEP 394 told me that /usr/bin/env python is wrong, so now I am going around and submitting 'Change python to python3 in shebang lines' PRs to every open source Python project I can find").

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@encukou

encukou commented Apr 26, 2019

Copy link
Copy Markdown
Member

I think requiring the python3 spelling is ultimately a transient thing

Is that your personal view, or can the SC agree on that? Last time I suggested this, it was explicitly shot down (#630 (comment)). This PR tries to reflect consensus from the mailing list (as much as possible while giving sound suggestions).

This is really frustrating – it feels like no one has the authoriity to decide, but too many people have a right to veto. And meanwhile, the status quo is inadequate; the PEP needs to be changed now if it's to keep any hope of relevance. This issue is good burnout material.

The explicit python3 will work now. It's good guidance for script authors that want their software to just work on users' machines.

Your script shebang lines are now wrong, and you should change them

Would it be OK to just add a disclaimer that while while the python3 suggestion works, different projects have different needs and other shebangs aren't necessarily wrong?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ncoghlan

ncoghlan commented Apr 26, 2019

Copy link
Copy Markdown
Contributor

(I'm currently commenting from a personal point of view, but I expect the merge decision on this PR will be made by SC consensus and/or vote)

The key outcome I want to avoid is anyone claiming "PEP 394 says that using /usr/bin/env python for source compatible scripts is always wrong", so yeah, I'd be OK with wording that made the points:

  • /usr/bin/env python3 is compatible with virtual environments, Python 3 only systems, and dual stack systems today, so choose this option if compatibility with newer Python 3 only systems is higher priority than compatibility with older Python 2 only systems (even for source-compatible scripts). This is often going to be the case for open source projects.
  • /usr/bin/env python is compatible with virtual environments, Python 2 only systems and dual stack systems today, and appears likely to become increasingly compatible with Python 3 only systems over time (assuming distros continue on the design trajectories that they're currently on), so choose this option if either compatibility with legacy Python 2 only systems is a high priority, or else if you have existing shebang lines that you'd prefer to leave unmodified for now.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ncoghlan @hroncok
PEP 394: Keep version agnostic shebang recommendation
268e96d
This update reverts back to the version agnostic "python" invocation
as the default recommendation for developers, and rewords the
rest of the PEP accordingly.

In particular, it makes it clear that publishers are free to adopt
the attitude of "we assume you are using a virtual environment",
while at the same time granting the distributors the freedom they
need to make software with the expectation work correctly when
run directly against a system Python installation.
@encukou
encukou requested a review from ncoghlan May 8, 2019 15:57
ncoghlan
ncoghlan approved these changes May 8, 2019
View reviewed changes

@ncoghlan ncoghlan left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me now. The big change from the initial PR is to keep the "/usr/bin/env python" recommendation as the default, but emphasise that this may require the use of virtual environments to provide cross platform consistency.

It then frames the additional freedom for Python distributors in terms of making their system Python installations behave more like a Python virtual environment.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@ncoghlan

ncoghlan commented May 8, 2019

Copy link
Copy Markdown
Contributor

@gvanrossum @brettcannon @gvanrossum @willingc I think this is ready for broader steering council review now.

General scope of change:

  • we grant Python distributors more freedom to either make the python name refer to the Python 3 runtime (the same way it will in a Python 3 virtual environment), or else make it configurable at the system level (again, more like virtual environments)
  • we clarify for publishers some of the trade-offs between the different options for targeting system installations directly
encukou reacted with thumbs up emoji pradyunsg reacted with hooray emoji
All reactions
  • 👍 1 reaction
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@encukou

encukou commented Jun 20, 2019

Copy link
Copy Markdown
Member

ping @warsaw. Care to reply? Anything I can do to make your job easier?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@brettcannon

brettcannon commented Jun 21, 2019

Copy link
Copy Markdown
Member

I'm going to put this on the steering council meeting agenda until Barry attends and notices this PR. 😄

willingc and pradyunsg reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@encukou

encukou commented Jun 24, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

We have a deadline coming up next Tuesday for Fedora 31 (scheduled to live 2019-10 to 2020-11). I'd like to let users have a working python command there by default.

Since this PR's recommendations for distros are, as far as I know, agreed on, I'm tempted to switch python to python3 even if the PEP is not updated in time.

(edit: corrected Fedora deadline date)

pradyunsg, willingc, and hroncok reacted with thumbs up emoji
All reactions
  • 👍 3 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ncoghlan

ncoghlan commented Jun 24, 2019

Copy link
Copy Markdown
Contributor

@encukou Aye, that makes sense, as the only thing holding this up are the remaining concerns regarding /usr/bin/env python as a default shebang recommendation for script publishers, even though it's the only venv-compatible option.

We also have a steering council meeting tomorrow morning, so I'll try to get it resolved then - it's the classic problem of "Most software publishers are not system integrators, so what's right for system integrators shouldn't affect the default recommendations" :)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ncoghlan added 2 commits June 26, 2019 08:27
@ncoghlan
Remove "preferred" shebang line wording
4b20f8c
@ncoghlan
Change post date
cca28c0
@ncoghlan

ncoghlan commented Jun 25, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Huh, since I deleted/edited the offending line I can't find a way to get back to the "single comment" thread that @warsaw started on the shebang line recommendation. (Found it via the commit history on the PR)

Anyway, 4b20f8c changes the mention of /usr/bin/env python to be specific to activated virtual environments (based on the 2019-06-26 SC discussion).

pradyunsg and hroncok reacted with hooray emoji
All reactions
  • 🎉 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

brettcannon
brettcannon approved these changes Jun 28, 2019
View reviewed changes
willingc
willingc approved these changes Jun 28, 2019
View reviewed changes
hroncok
hroncok commented Jun 28, 2019
View reviewed changes
Comment thread pep-0394.txt Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread pep-0394.txt Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread pep-0394.txt Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread pep-0394.txt Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread pep-0394.txt Resolved

Uh oh!

There was an error while loading. Please reload this page.

hroncok
hroncok commented Jun 28, 2019
View reviewed changes

@hroncok hroncok left a comment

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've read the entire proposal again and from the Fedora POV I'm in favor!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

willingc reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@hroncok
Little tweaks
5d3e9d8
@hroncok
hroncok force-pushed the pep394-2019 branch from 533f73c to 5d3e9d8 Compare June 28, 2019 14:12
@hroncok

hroncok commented Jun 28, 2019

Copy link
Copy Markdown
Contributor Author

The GitHub interface had some whitespace problem and I've broke the RST syntax, Sorry about that, should be good now.

willingc reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

warsaw
warsaw requested changes Jun 28, 2019
View reviewed changes

@warsaw warsaw left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ncoghlan Thanks very much for the changes regarding /usr/bin/env. With the focus on venvs, I think the recommendations in the PEP are great now. I do have a few suggestions for improvements to the text, but I think these are mostly minor.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ncoghlan reacted with hooray emoji willingc reacted with heart emoji
All reactions
  • 🎉 1 reaction
  • ❤️ 1 reaction
Comment thread pep-0394.txt Outdated
discrepancies across platforms and installation methods:

* Older Linux distributions will provide a ``python`` command that
refers to Python 2. Most of these distros do *not* provide a

@warsaw warsaw Jun 28, 2019

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The second sentence feels a little too imprecise. What exactly is an "older Linux distribution" and how many of them count as "most"? Perhaps:

Older Linux distributions will provide a python command that refers to Python 2, and will likely not provide a python2 command

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

willingc and hroncok reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
Comment thread pep-0394.txt Outdated
is released.
* Even as the Python 2 interpreter becomes less common, it remains reasonable
for scripts to continue to use the ``python3`` convention, rather than just
``python``. In the event of a future Python 4.0 release, distributors may

@warsaw warsaw Jun 28, 2019

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest leaving out any mention of Python 4. 1) it can create FUD; 2) it's entirely vaporware; 3) we don't even know whether there will be a Python 4 or what it will look like. We can always add a Python 4 recommendation when the time comes.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

hroncok and Jamim reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

@willingc willingc Jun 28, 2019

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. Good catch @warsaw

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@encukou
Address review comments
6dbfc2f
- Clarify wording on "older" Linux distros
- Remove discussion aroung Python 4.0
@encukou

encukou commented Jul 4, 2019

Copy link
Copy Markdown
Member

@ncoghlan I pushed a change addressing the issues above. Do you have any comments on them?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ncoghlan
ncoghlan approved these changes Jul 4, 2019
View reviewed changes
@ncoghlan

ncoghlan commented Jul 4, 2019

Copy link
Copy Markdown
Contributor

LGTM! @warsaw, over to you for the final review & merge :)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

warsaw
warsaw approved these changes Jul 5, 2019
View reviewed changes

@warsaw warsaw left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks everyone, for working together on this important update.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

pradyunsg, Jamim, and encukou reacted with hooray emoji
All reactions
  • 🎉 3 reactions
@warsaw
warsaw merged commit ae932bd into python:master Jul 5, 2019
@hroncok
hroncok deleted the pep394-2019 branch July 5, 2019 19:16
@hroncok

hroncok commented Jul 5, 2019

Copy link
Copy Markdown
Contributor Author

Thank you!

encukou and ktdreyer reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@lazka lazka mentioned this pull request Jul 9, 2019
Python 3 as default python msys2/MINGW-packages#4950
Closed
@sparunakian sparunakian mentioned this pull request Oct 10, 2019
new interpreter discovery does not support non-RH distros ansible/ansible#61534
Closed
@ryneeverett ryneeverett mentioned this pull request Mar 6, 2020
Migrate to Python 3 as default install NixOS/nixpkgs#18185
Closed
2 of 3 tasks
@keith keith mentioned this pull request Apr 21, 2022
Use python3 instead of python ninja-build/ninja#2118
Closed
@encukou encukou mentioned this pull request Jan 3, 2023
gh-98763: Prefer "python" over "python3" for command line examples in docs. python/cpython#98761
Merged
@Suncatcher Suncatcher mentioned this pull request Oct 6, 2024
v5.0.0beta: Python Runtime can't be found despite manually setting the Python path qbittorrent/qBittorrent#20737
Closed
@reegnz reegnz mentioned this pull request Mar 14, 2025
pyenv-virtualenv is not compatible with brew pyenv-sync pyenv/pyenv-virtualenv#505
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukou encukou encukou left review comments
@Rosuav Rosuav Rosuav left review comments
@willingc willingc willingc approved these changes
@brettcannon brettcannon brettcannon approved these changes
@warsaw warsaw warsaw approved these changes
@ncoghlan ncoghlan ncoghlan approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

CLA signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

9 participants

@hroncok @gvanrossum @encukou @warsaw @ncoghlan @brettcannon @willingc @Rosuav @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.