GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-7: Add unit tests for pure configuration helpers. by breadonb · Pull Request #392 · python/pymanager

Conversation

@breadonb

@breadonb breadonb commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

This PR adds unit tests for the dependency-free helper functions in manage.config.

Refs #7

Functions tested

  • config_bool
  • _expand_vars
  • config_append
  • config_dict_merge
  • config_split
  • config_split_append

Coverage for config.py increased from 17% to 30%. The full test suite increased from 415 to 456 tests, with all tests passing.

The tests satisfy the constraint from the issue by importing the functions directly and passing plain strings and dictionaries. They do not rely on a py command, the filesystem, the registry, _native, or any new dependency.

I deliberately scoped this PR to the dependency-free helpers. Tests for resolve_config, merge_config, and the load_* functions would be a natural follow-up.

Tested on Windows with Python 3.14.4 and pytest 9.1.1.

One behavior captured by the tests is that : is a delimiter for config_split, so "C:\\tools" splits into ["C", "\tools"]. The test test_config_split[windows_path] documents the current behavior rather than proposing a change.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@breadonb
pythongh-7: Add unit tests for pure configuration helpers.
866e56f
@python-cla-bot

python-cla-bot Bot commented Aug 1, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@breadonb breadonb mentioned this pull request Aug 1, 2026
Test coverage #7
Open
@zooba

zooba commented Aug 18, 2026

Copy link
Copy Markdown
Member

Thanks! Appreciate this

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@zooba
zooba merged commit b312cc1 into python:main Aug 18, 2026
4 checks passed

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@breadonb @zooba
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.