GeezerVison is showing github.com — Fixes split_args handling of quotes that start or end inside an argument. by RaphaelFakhri · Pull Request #439 · python/pymanager
Conversation
split_args parses the ExecutableArguments and WindowedExecutableArguments values of PEP 514 registrations. It only handles quotes that wrap a whole argument. When a quote starts or ends inside an argument, the parser keeps a stray quote (-W"ignore" becomes -W"ignore) or drops text ("a b"c becomes a b). It also collapses \\ outside quotes and turns doubled spaces into empty arguments.
This change replaces the parser with a character-by-character implementation of the C runtime rules:
- Whitespace (space or tab) outside quotes separates arguments.
2n backslashes followed by a quote produce n backslashes and toggle quoting.
2n+1 backslashes followed by a quote produce n backslashes and a literal quote.
- A doubled quote inside a quoted section produces a literal quote.
- Other backslashes are kept as is.
The new test_split_args cases include the examples from Parsing C command-line arguments. The existing quote_args round-trip cases still pass.
Fixes #438
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
All commit authors signed the Contributor License Agreement.

|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.